[GitHub] [commons-lang] garydgregory commented on pull request #219: LANG-341: Add number to byte array methods to org.apache.commons.lang3.Conversion

[GitBox <gi...@apache.org>]

garydgregory commented on pull request #219:
URL: https://github.com/apache/commons-lang/pull/219#issuecomment-809300879


   We know the build fails on Java 16, there is a separate thread about that
   on the dev ML. It looks like a problem in our data parser or possibly an
   issue in the JDK, hard to say, but we do need help figuring it out.
   
   Gary
   
   On Sun, Mar 28, 2021, 18:16 yurelle ***@***.***> wrote:
   
   > Ok, I fixed the merge conflicts and all the new build style tests that
   > have been added since I first made this PR back in 2016. And the build
   > works for Java 8, but it is dying on the Java 16 build. The errors are
   > complaining about stuff that I didn't touch, so I don't think this is my
   > doing.
   >
   > Also, back when I wrote all this code, I wasn't allowed to use stuff that
   > was added in Java 8 (specifically the BYTES static property that was added
   > to the Primitive object classes). So, I manually created equivalent integer
   > constants in the Conversion class. However, judging by the versions in the
   > automated builds, it appears that java 8 is now the min supported version.
   > If that is the case, then I can update this code to use the Java 8 BYTES
   > fields, and remove the integer constants. Can you confirm if I'm allowed to
   > use stuff that was introduced in Java 8?
   >
   > Also, @dmjones <https://github.com/dmjones> mentioned a desire to have
   > the PR broken up into chunks to make review easier. I can do that if you
   > want, but I need to know how small you want those chunks to be. My original
   > commit message split the changes into 4 groups of functions:
   >
   >    - primitive to byte[] and back
   >    - hex to primitive and back
   >    - bit strings
   >    - invert bit order
   >
   > Would these 4 PR's be sufficient? or do you want it more fine grained?
   >
   > As for the whitespace, Intellij did it automatically; I'm not sure how to
   > undo it.
   >
   > -Yurelle
   >
   > P.S. Sorry for leaving this in limbo for so long, but I've had depression
   > for several years, and with a full-time job, I haven't had the energy to do
   > much else. But I've had some time recently, and I'd like to finally get
   > this finished, if yall still want it.
   >
   > —
   > You are receiving this because you commented.
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/commons-lang/pull/219#issuecomment-808968232>,
   > or unsubscribe
   > <https://github.com/notifications/unsubscribe-auth/AAJB6NZQ7CR5WU62E45545DTF6TETANCNFSM4CXUBPHQ>
   > .
   >
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org