Re: [PR] [FLINK-40232][table-runtime] Handle null rowtime in OutputConversionOperator [flink]

["imankhadiv (via GitHub)" <gi...@apache.org>]

imankhadiv commented on PR #29027:
URL: https://github.com/apache/flink/pull/29027#issuecomment-5779785762

   Gentle ping — this has been green since Aug 28 (Azure build 78461 on `a0142a2`) and the review nit from @davidradl is addressed.
   
   @snuyanzin would you have a moment to take a look? It's a small `flink-table-runtime` change: both rowtime lookups in `OutputConversionOperator` are null-guarded via a shared `updateRowtime` helper, and the null branch calls `eraseTimestamp()` — `outRecord` is a single `StreamRecord` reused across elements and `replace(Object)` leaves the timestamp untouched, so skipping `setTimestamp()` alone would leak the previous record's timestamp rather than fix the NPE. FLINK-40232 is assigned to me and the test covers both the NPE and the stale-timestamp case (verified red before green).
   
   Happy to rebase or adjust if anything is needed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org