You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Bernd Mathiske <be...@mesosphere.io> on 2015/02/27 20:08:44 UTC
Review Request 31554: Fetcher tests should now build again on ubuntu
14.10
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31554/
-----------------------------------------------------------
Review request for mesos and Vinod Kone.
Bugs: MESOS-2420
https://issues.apache.org/jira/browse/MESOS-2420
Repository: mesos
Description
-------
Found 2 signed-unsigned comparisons, replaced "0" with "0u" to make it unsigned-unsigned.
Diffs
-----
src/tests/fetcher_tests.cpp 0ae0a10b41a2c0f7459c771b31c76bbc0c02df4f
Diff: https://reviews.apache.org/r/31554/diff/
Testing
-------
Not the real thing, i.e. did not test on Ubuntu 14.10 as in the bug report. However, I am quite confident that this is the right fix and I want to provide it ASAP. Will test on Ubuntu 14.10 once I have it.
Compiles on MacOS 10.10 and Ubuntu 14.04.
Thanks,
Bernd Mathiske
Re: Review Request 31554: Fetcher tests should now build again on
ubuntu 14.10
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31554/#review74549
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On Feb. 27, 2015, 7:08 p.m., Bernd Mathiske wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31554/
> -----------------------------------------------------------
>
> (Updated Feb. 27, 2015, 7:08 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-2420
> https://issues.apache.org/jira/browse/MESOS-2420
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Found 2 signed-unsigned comparisons, replaced "0" with "0u" to make it unsigned-unsigned.
>
>
> Diffs
> -----
>
> src/tests/fetcher_tests.cpp 0ae0a10b41a2c0f7459c771b31c76bbc0c02df4f
>
> Diff: https://reviews.apache.org/r/31554/diff/
>
>
> Testing
> -------
>
> Not the real thing, i.e. did not test on Ubuntu 14.10 as in the bug report. However, I am quite confident that this is the right fix and I want to provide it ASAP. Will test on Ubuntu 14.10 once I have it.
>
> Compiles on MacOS 10.10 and Ubuntu 14.04.
>
>
> Thanks,
>
> Bernd Mathiske
>
>