[GitHub] [trafficcontrol] ocket8888 commented on pull request #6978: Add t3c support for __CACHEKEY_DIRECTIVE__ in raw remap text

[GitBox <gi...@apache.org>]

ocket8888 commented on PR #6978:
URL: https://github.com/apache/trafficcontrol/pull/6978#issuecomment-1191862088

   >  It isn't replaced in any other locations, like the doc says and like all those other directives are.
   
   That's not strictly true. That section is also appropriate for replacements restricted to a single file, for example the `##OVERRIDE##` description reads:
   
   > This string is only valid in the content of files named “remap.config”.
   
   But looking at the code this isn't just restricted to a single configuration file it's, as you say:
   
   > ... only replaced inside the DS Raw Remap Text...
   
   which I didn't realize right away. So
   
   > This does add docs for the particular DS field it affects. Is that sufficient?
   
   Yes.
   
   > Or if you want, I guess we could add some kind of line to the `the list of strings with special meaning to t3c` doc, "see individual Delivery Service and Server fields for replacements unique to data in those fields" or something?
   
   No, I don't think that's necessary.
   
   > Also removing the low_impact tag, if that's ok.
   
   The point is just that it should have *some* impact level tag. I just took a guess at what that would be but you should absolutely replace it with whichever is more appropriate.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org