You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2022/06/29 06:41:49 UTC
[GitHub] [servicecomb-java-chassis] lbc97 opened a new pull request, #3153: [SCB-2620] The long polling time is changed to be obtained from the c…
lbc97 opened a new pull request, #3153:
URL: https://github.com/apache/servicecomb-java-chassis/pull/3153
…onfiguration item.
Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Run `mvn clean install -Pit` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] codecov-commenter commented on pull request #3153: [SCB-2620] The long polling time is changed to be obtained from the c…
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #3153:
URL: https://github.com/apache/servicecomb-java-chassis/pull/3153#issuecomment-1170663486
# [Codecov](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3153?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#3153](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3153?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ba4710c) into [master](https://codecov.io/gh/apache/servicecomb-java-chassis/commit/6e2df7eafbdcd7609c2e97cb55f0efe4f69ddf45?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6e2df7e) will **increase** coverage by `0.00%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head ba4710c differs from pull request most recent head aaa6240. Consider uploading reports for the commit aaa6240 to get more accurate results
```diff
@@ Coverage Diff @@
## master #3153 +/- ##
=========================================
Coverage 77.46% 77.47%
Complexity 1439 1439
=========================================
Files 1617 1617
Lines 43269 43273 +4
Branches 3643 3643
=========================================
+ Hits 33520 33525 +5
+ Misses 8248 8245 -3
- Partials 1501 1503 +2
```
| [Impacted Files](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3153?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ervicecomb/config/kie/client/KieConfigManager.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3153/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50cy9jb25maWcta2llLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvY29uZmlnL2tpZS9jbGllbnQvS2llQ29uZmlnTWFuYWdlci5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...comb/config/kie/client/model/KieConfiguration.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3153/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50cy9jb25maWcta2llLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvY29uZmlnL2tpZS9jbGllbnQvbW9kZWwvS2llQ29uZmlndXJhdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...icecomb/config/kie/KieConfigurationSourceImpl.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3153/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHluYW1pYy1jb25maWcvY29uZmlnLWtpZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvY29uZmlnL2tpZS9LaWVDb25maWd1cmF0aW9uU291cmNlSW1wbC5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...mb/metrics/core/meter/os/cpu/AbstractCpuUsage.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3153/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bWV0cmljcy9tZXRyaWNzLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NlcnZpY2Vjb21iL21ldHJpY3MvY29yZS9tZXRlci9vcy9jcHUvQWJzdHJhY3RDcHVVc2FnZS5qYXZh) | `88.88% <0.00%> (-11.12%)` | :arrow_down: |
| [.../servicecomb/registry/discovery/DiscoveryTree.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3153/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Zm91bmRhdGlvbnMvZm91bmRhdGlvbi1yZWdpc3RyeS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvcmVnaXN0cnkvZGlzY292ZXJ5L0Rpc2NvdmVyeVRyZWUuamF2YQ==) | `96.49% <0.00%> (-3.51%)` | :arrow_down: |
| [...mb/config/ConfigCenterConfigurationSourceImpl.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3153/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHluYW1pYy1jb25maWcvY29uZmlnLWNjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zZXJ2aWNlY29tYi9jb25maWcvQ29uZmlnQ2VudGVyQ29uZmlndXJhdGlvblNvdXJjZUltcGwuamF2YQ==) | `10.63% <0.00%> (+1.06%)` | :arrow_up: |
| [...egistry/client/http/ServiceRegistryClientImpl.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3153/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2VydmljZS1yZWdpc3RyeS9yZWdpc3RyeS1zZXJ2aWNlLWNlbnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvc2VydmljZXJlZ2lzdHJ5L2NsaWVudC9odHRwL1NlcnZpY2VSZWdpc3RyeUNsaWVudEltcGwuamF2YQ==) | `71.31% <0.00%> (+1.14%)` | :arrow_up: |
| [...mb/serviceregistry/client/http/RestClientUtil.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3153/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2VydmljZS1yZWdpc3RyeS9yZWdpc3RyeS1zZXJ2aWNlLWNlbnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvc2VydmljZXJlZ2lzdHJ5L2NsaWVudC9odHRwL1Jlc3RDbGllbnRVdGlsLmphdmE=) | `80.37% <0.00%> (+1.86%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3153?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3153?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [6e2df7e...aaa6240](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3153?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] liubao68 merged pull request #3153: [SCB-2620] The long polling time is changed to be obtained from the c…
Posted by GitBox <gi...@apache.org>.
liubao68 merged PR #3153:
URL: https://github.com/apache/servicecomb-java-chassis/pull/3153
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] liubao68 commented on a diff in pull request #3153: [SCB-2620] The long polling time is changed to be obtained from the c…
Posted by GitBox <gi...@apache.org>.
liubao68 commented on code in PR #3153:
URL: https://github.com/apache/servicecomb-java-chassis/pull/3153#discussion_r909478419
##########
dynamic-config/config-kie/src/main/java/org/apache/servicecomb/config/kie/KieConfigurationSourceImpl.java:
##########
@@ -120,6 +120,7 @@ private KieConfiguration createKieConfiguration() {
.setEnvironment(KieConfig.INSTANCE.getEnvironment())
.setPollingWaitInSeconds(KieConfig.INSTANCE.getPollingWaitTime())
.setProject(KieConfig.INSTANCE.getDomainName())
+ .setRefreshInterval(KieConfig.INSTANCE.getRefreshInterval())
Review Comment:
default value should be 15 seconds
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] liubao68 commented on a diff in pull request #3153: [SCB-2620] The long polling time is changed to be obtained from the c…
Posted by GitBox <gi...@apache.org>.
liubao68 commented on code in PR #3153:
URL: https://github.com/apache/servicecomb-java-chassis/pull/3153#discussion_r909517332
##########
clients/config-kie-client/src/main/java/org/apache/servicecomb/config/kie/client/KieConfigManager.java:
##########
@@ -132,7 +132,7 @@ public void execute() {
if (KieConfigManager.this.kieConfiguration.isEnableLongPolling()) {
startTask(new BackOffSleepTask(LONG_POLLING_INTERVAL, new PollConfigurationTask(0, this.configurationsRequest)));
} else {
- startTask(new BackOffSleepTask(POLLING_INTERVAL, new PollConfigurationTask(0, this.configurationsRequest)));
+ startTask(new BackOffSleepTask(kieConfiguration.getRefreshInterval(), new PollConfigurationTask(0, this.configurationsRequest)));
Review Comment:
delete unused POLLING_INTERVAL param
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] liubao68 commented on a diff in pull request #3153: [SCB-2620] The long polling time is changed to be obtained from the c…
Posted by GitBox <gi...@apache.org>.
liubao68 commented on code in PR #3153:
URL: https://github.com/apache/servicecomb-java-chassis/pull/3153#discussion_r909478907
##########
clients/config-kie-client/src/main/java/org/apache/servicecomb/config/kie/client/model/KieConfiguration.java:
##########
@@ -22,6 +22,9 @@ public class KieConfiguration {
private int pollingWaitInSeconds;
+ private int refreshInterval;
Review Comment:
give a default value too. Other frameworks may missed the setting when integrate this version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org