[GitHub] [accumulo] ctubbsii commented on a diff in pull request #3664: change exit error code for ZooPropEditor

["ctubbsii (via GitHub)" <gi...@apache.org>]

ctubbsii commented on code in PR #3664:
URL: https://github.com/apache/accumulo/pull/3664#discussion_r1278006895


##########
server/base/src/main/java/org/apache/accumulo/server/conf/util/ZooPropEditor.java:
##########
@@ -114,7 +114,7 @@ public void execute(String[] args) throws Exception {
     } catch (Exception ex) {
       LOG.error("{} command failed", keyword(), ex);
       // hard fail - set exit status
-      System.exit(-1);
+      System.exit(1);

Review Comment:
   Although the non-negative exit code is better, I don't see much value in intercepting the failure, logging it, and then exiting the process, when letting the exception fall through would basically do the same thing by default.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org