You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by bu...@apache.org on 2011/11/19 00:29:32 UTC
DO NOT REPLY [Bug 52213] New: Field
"org.apache.catalina.tribes.transport.bio.util.FastQueue.enabled" should be
volatile.
https://issues.apache.org/bugzilla/show_bug.cgi?id=52213
Bug #: 52213
Summary: Field
"org.apache.catalina.tribes.transport.bio.util.FastQue
ue.enabled" should be volatile.
Product: Tomcat 7
Version: trunk
Platform: PC
OS/Version: Linux
Status: NEW
Severity: normal
Priority: P2
Component: Catalina
AssignedTo: dev@tomcat.apache.org
ReportedBy: reprogrammer@gmail.com
Classification: Unclassified
The boolean flag
"org.apache.catalina.tribes.transport.bio.util.FastQueue.enabled" may be
read/written by multiple threads concurrently (See
<http://svn.apache.org/repos/asf/!svn/bc/1203897/tomcat/trunk/java/org/apache/catalina/tribes/group/interceptors/MessageDispatchInterceptor.java>).
Therefore, accesses to it should be properly synchronized. It is sufficient to
make this boolean flag volatile to protect access to it.
See
<https://www.securecoding.cert.org/confluence/display/java/VNA00-J.+Ensure+visibility+when+accessing+shared+primitive+variables>
for more information about this bug pattern.
Keshmesh (https://keshmesh.cs.illinois.edu/) is an Eclipse plugin that
analyzes the source code of Java programs for common concurrency bug patterns.
We used Keshmesh to detect this concurrency bug pattern.
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
DO NOT REPLY [Bug 52213] Field
"org.apache.catalina.tribes.transport.bio.util.FastQueue.enabled" should be
volatile.
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=52213
Mohsen Vakilian <re...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |reprogrammer@gmail.com
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
DO NOT REPLY [Bug 52213] Field
"org.apache.catalina.tribes.transport.bio.util.FastQueue.enabled" should be
volatile.
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=52213
--- Comment #2 from Mohsen Vakilian <re...@gmail.com> 2011-11-25 19:02:47 UTC ---
Please note that the underlying problem is similar to Bug 48235.
Keshmesh <http://keshmesh.cs.illinois.edu/> detected the unprotected flag
"FastQueue.enabled" when we annotated
"org.apache.catalina.tribes.group.interceptors.MessageDispatchInterceptor.run()"
as an entry method.
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
DO NOT REPLY [Bug 52213] Field
"org.apache.catalina.tribes.transport.bio.util.FastQueue.enabled" should be
volatile.
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=52213
Mark Thomas <ma...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED
--- Comment #3 from Mark Thomas <ma...@apache.org> 2011-12-23 21:16:31 UTC ---
Fixed in trunk and 7.0.x and will be included in 7.0.24 onwards.
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
DO NOT REPLY [Bug 52213] Field
"org.apache.catalina.tribes.transport.bio.util.FastQueue.enabled" should be
volatile.
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=52213
--- Comment #1 from Mohsen Vakilian <re...@gmail.com> 2011-11-18 23:31:22 UTC ---
(In reply to comment #0)
> The boolean flag
> "org.apache.catalina.tribes.transport.bio.util.FastQueue.enabled" may be
> read/written by multiple threads concurrently (See
> <http://svn.apache.org/repos/asf/!svn/bc/1203897/tomcat/trunk/java/org/apache/catalina/tribes/group/interceptors/MessageDispatchInterceptor.java>).
> Therefore, accesses to it should be properly synchronized. It is sufficient to
> make this boolean flag volatile to protect access to it.
>
> See
> <https://www.securecoding.cert.org/confluence/display/java/VNA00-J.+Ensure+visibility+when+accessing+shared+primitive+variables>
> for more information about this bug pattern.
>
> Keshmesh (https://keshmesh.cs.illinois.edu/) is an Eclipse plugin that
> analyzes the source code of Java programs for common concurrency bug patterns.
> We used Keshmesh to detect this concurrency bug pattern.
I made a typo in the URL of Keshmesh the correct URL is
<http://keshmesh.cs.illinois.edu/>.
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org