[GitHub] [spark] viirya commented on a change in pull request #31682: [WIP][SPARK-34545][SQL] Fix row comparisons

[GitBox <gi...@apache.org>]

viirya commented on a change in pull request #31682:
URL: https://github.com/apache/spark/pull/31682#discussion_r584483705



##########
File path: sql/catalyst/src/test/scala/org/apache/spark/sql/RowTest.scala
##########
@@ -108,6 +108,31 @@ class RowTest extends AnyFunSpec with Matchers {
     }
   }
 
+  describe("row not equals") {
+    val externalRow = Row(1)
+    val externalRow2 = Row(1.0)
+
+    it("inequality check for external rows") {
+      externalRow should not equal externalRow2
+    }

Review comment:
       Hmm, isn't this somehow arguable? Especially 1 == 1.0 => true.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org