You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by xguo27 <gi...@git.apache.org> on 2015/12/25 05:18:09 UTC
[GitHub] spark pull request: [SPARK-12521][SQL][WIP] JDBCRelation does not ...
GitHub user xguo27 opened a pull request:
https://github.com/apache/spark/pull/10473
[SPARK-12521][SQL][WIP] JDBCRelation does not honor lowerBound/upperBound
JDBCRelation is not bounding the rows when lowerBound/upperBound are given. This change honors the bounds given.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/xguo27/spark SPARK-12521
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/10473.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #10473
----
commit b0d03592716369edb390f7811a5d4d530bb0cfe2
Author: Xiu Guo <xg...@gmail.com>
Date: 2015-12-25T04:08:35Z
[SPARK-12521][SQL] JDBCRelation does not honor lowerBound/upperBound
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-12521][SQL][WIP] JDBCRelation does not ...
Posted by xguo27 <gi...@git.apache.org>.
Github user xguo27 commented on the pull request:
https://github.com/apache/spark/pull/10473#issuecomment-167190872
Marking it [WIP] to invite discussion here. : ) As I suspect the original code includes infinity on both smaller than side and greater than side for a reason.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-12521][SQL][WIP] JDBCRelation does not ...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10473#issuecomment-167190846
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-12521][SQL][WIP] JDBCRelation does not ...
Posted by xguo27 <gi...@git.apache.org>.
Github user xguo27 closed the pull request at:
https://github.com/apache/spark/pull/10473
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-12521][SQL][WIP] JDBCRelation does not ...
Posted by xguo27 <gi...@git.apache.org>.
Github user xguo27 commented on the pull request:
https://github.com/apache/spark/pull/10473#issuecomment-167258976
Thanks @hvanhovell for clarifying it up. I will close this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-12521][SQL][WIP] JDBCRelation does not ...
Posted by hvanhovell <gi...@git.apache.org>.
Github user hvanhovell commented on the pull request:
https://github.com/apache/spark/pull/10473#issuecomment-167214192
@xguo27 see my comment on the JIRA: https://issues.apache.org/jira/browse/SPARK-12521
I think this is intended, and should not be altered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org