You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by abdelhakim deneche <ad...@gmail.com> on 2015/06/25 21:38:09 UTC
Review Request 35887: DRILL-3312: PageReader.allocatePageData() calls
BufferAllocator.buffer(int) but doesn't check if the result is null
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35887/
-----------------------------------------------------------
Review request for drill and Hanifi Gunes.
Bugs: DRILL-3312
https://issues.apache.org/jira/browse/DRILL-3312
Repository: drill-git
Description
-------
made sure all calls to BufferAllocator.buffer() throw an OOM if the buffer is null
Diffs
-----
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/PageReader.java 8c73b2a
Diff: https://reviews.apache.org/r/35887/diff/
Testing
-------
all unit tests are passing along with functional and tpch100
Thanks,
abdelhakim deneche
Re: Review Request 35887: DRILL-3312: PageReader.allocatePageData()
calls
BufferAllocator.buffer(int) but doesn't check if the result is null
Posted by abdelhakim deneche <ad...@gmail.com>.
> On July 2, 2015, 5:17 a.m., Hanifi Gunes wrote:
> > exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/PageReader.java, line 305
> > <https://reviews.apache.org/r/35887/diff/1/?file=992327#file992327line305>
> >
> > This change does not seem needed after 3445. Should we discard it?
Yes, I will mark the corresponding JIRA as duplicate
- abdelhakim
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35887/#review90195
-----------------------------------------------------------
On June 25, 2015, 7:38 p.m., abdelhakim deneche wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35887/
> -----------------------------------------------------------
>
> (Updated June 25, 2015, 7:38 p.m.)
>
>
> Review request for drill and Hanifi Gunes.
>
>
> Bugs: DRILL-3312
> https://issues.apache.org/jira/browse/DRILL-3312
>
>
> Repository: drill-git
>
>
> Description
> -------
>
> made sure all calls to BufferAllocator.buffer() throw an OOM if the buffer is null
>
>
> Diffs
> -----
>
> exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/PageReader.java 8c73b2a
>
> Diff: https://reviews.apache.org/r/35887/diff/
>
>
> Testing
> -------
>
> all unit tests are passing along with functional and tpch100
>
>
> Thanks,
>
> abdelhakim deneche
>
>
Re: Review Request 35887: DRILL-3312: PageReader.allocatePageData()
calls
BufferAllocator.buffer(int) but doesn't check if the result is null
Posted by Hanifi Gunes <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35887/#review90195
-----------------------------------------------------------
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/PageReader.java (line 305)
<https://reviews.apache.org/r/35887/#comment143197>
This change does not seem needed after 3445. Should we discard it?
- Hanifi Gunes
On June 25, 2015, 7:38 p.m., abdelhakim deneche wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35887/
> -----------------------------------------------------------
>
> (Updated June 25, 2015, 7:38 p.m.)
>
>
> Review request for drill and Hanifi Gunes.
>
>
> Bugs: DRILL-3312
> https://issues.apache.org/jira/browse/DRILL-3312
>
>
> Repository: drill-git
>
>
> Description
> -------
>
> made sure all calls to BufferAllocator.buffer() throw an OOM if the buffer is null
>
>
> Diffs
> -----
>
> exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/PageReader.java 8c73b2a
>
> Diff: https://reviews.apache.org/r/35887/diff/
>
>
> Testing
> -------
>
> all unit tests are passing along with functional and tpch100
>
>
> Thanks,
>
> abdelhakim deneche
>
>