[GitHub] [superset] john-bodley commented on a change in pull request #16917: refactor: sql lab command: separate concerns into different modules

[GitBox <gi...@apache.org>]

john-bodley commented on a change in pull request #16917:
URL: https://github.com/apache/superset/pull/16917#discussion_r724329925



##########
File path: superset/charts/dao.py
##########
@@ -14,6 +14,7 @@
 # KIND, either express or implied.  See the License for the
 # specific language governing permissions and limitations
 # under the License.
+# pylint: disable=arguments-renamed

Review comment:
       @ofekisr could we move these to the lines where the issue occurs? There was an effort in https://github.com/apache/superset/pull/16589 to remove top-level Pylint disable checks as it's i) unclear to the reader where these violations are occurring, and ii) potentially masks issues in future changes.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org