You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/04/16 15:26:51 UTC

[GitHub] [incubator-tvm] mbaret opened a new pull request #5348: [BYOC][FIX] Fix typo in "default"

mbaret opened a new pull request #5348: [BYOC][FIX] Fix typo in "default"
URL: https://github.com/apache/incubator-tvm/pull/5348
 
 
   Default annotations were incorrectly being named 'defualt' which results in them not being removed in PartitionGraph.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-tvm] mbaret commented on issue #5348: [BYOC][FIX] Fix typo in "default"

Posted by GitBox <gi...@apache.org>.
mbaret commented on issue #5348: [BYOC][FIX] Fix typo in "default"
URL: https://github.com/apache/incubator-tvm/pull/5348#issuecomment-614723215
 
 
   cc @comaniac @zhiics @manupa-arm 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-tvm] tqchen merged pull request #5348: [BYOC][FIX] Fix typo in "default"

Posted by GitBox <gi...@apache.org>.
tqchen merged pull request #5348: [BYOC][FIX] Fix typo in "default"
URL: https://github.com/apache/incubator-tvm/pull/5348
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-tvm] comaniac commented on issue #5348: [BYOC][FIX] Fix typo in "default"

Posted by GitBox <gi...@apache.org>.
comaniac commented on issue #5348: [BYOC][FIX] Fix typo in "default"
URL: https://github.com/apache/incubator-tvm/pull/5348#issuecomment-614780555
 
 
   Thanks for the fix. Apparently our unit tests didn't cover this case. Would you be able to improve the unit test a bit to cover it? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services