You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@zeppelin.apache.org by "tbonelee (via GitHub)" <gi...@apache.org> on 2024/11/15 15:31:09 UTC

[PR] [ZEPPELIN-6151] Remove AngularJS -> Angular Code Migration Suggestion Feature [zeppelin]

tbonelee opened a new pull request, #4900:
URL: https://github.com/apache/zeppelin/pull/4900

   ### What is this PR for?
   I propose removing the feature in Zeppelin's new UI that converts AngularJS code to Angular code.
   
   This feature currently prompts users when they run code with the `%angular` prefix, asking whether to migrate AngularJS code to Angular, and performs the migration if confirmed.
   
   The reasons for suggesting its removal are as follows:
   
   - The library supporting this feature is not compatible with the latest Angular versions due to peer dependency issues, making it difficult to upgrade Angular.
   - It is likely that this feature is not widely used by the community.
   
   Removing this feature will reduce unnecessary library dependencies, which will help streamline future updates to the latest Angular versions.
   
   If you have any other opinions, please feel free to share them.
   
   ### What type of PR is it?
   Removing Feature
   
   ### Todos
   * [ ] - Task
   
   ### What is the Jira issue?
   https://issues.apache.org/jira/browse/ZEPPELIN-6151
   
   ### How should this be tested?
   * Strongly recommended: add automated unit tests for any new or changed behavior
   * Outline any manual steps to test the PR here.
   
   ### Screenshots (if appropriate)
   
   ### Questions:
   * Does the license files need to update? No
   * Is there breaking changes for older versions? No
   * Does this needs documentation? No
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [ZEPPELIN-6151] Remove AngularJS -> Angular Code Migration Suggestion Feature [zeppelin]

Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on PR #4900:
URL: https://github.com/apache/zeppelin/pull/4900#issuecomment-2496595848

   Thanks, merged to master/0.12


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [ZEPPELIN-6151] Remove AngularJS -> Angular Code Migration Suggestion Feature [zeppelin]

Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 merged PR #4900:
URL: https://github.com/apache/zeppelin/pull/4900


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org