You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@magpie.apache.org by "potiuk (via GitHub)" <gi...@apache.org> on 2026/10/18 18:02:58 UTC

[PR] test(adversarial-review): give the timing tests room to start their stubs [magpie]

potiuk opened a new pull request, #1699:
URL: https://github.com/apache/magpie/pull/1699

   Three adversarial-review runner tests measure wall-clock time against bounds that left too little room for starting the Python stub reviewers.
   Under load (the pre-commit hook runs the workspace pytest members in parallel) they failed intermittently and blocked unrelated commits.
   
   - `test_one_timeout_does_not_block_the_others`: the reviewer that should answer had a 1 s budget, which its own start-up could use up. It now has 5 s; the other stub still sleeps for a minute, so it still times out.
   - `test_reviewers_run_in_parallel_and_keep_order`: two 1.5 s reviewers had to finish under 2.8 s (3.03 s seen). Now 3 s each under 5.5 s; one after the other they take 6 s.
   - `test_a_finished_answer_is_kept_when_a_helper_lingers`: under 8 s with a 10 s timeout instead of under 4 s with 5 s.
   
   Each test still tells the behaviour apart from its failure mode. Test-only change.
   
   ---
   
   ##### Was generative AI tooling used to co-author this PR?
   
   - [x] Yes — Claude Code (Opus 5)
   
   Generated-by: Claude Code (Opus 5) following [the guidelines](https://github.com/apache/magpie/blob/main/CONTRIBUTING.md)
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@magpie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] test(adversarial-review): give the timing tests room to start their stubs [magpie]

Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #1699:
URL: https://github.com/apache/magpie/pull/1699


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@magpie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org