You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/03/03 14:43:18 UTC
[GitHub] [incubator-nuttx] Ouss4 opened a new pull request #2965: ESP32XX: Add more flash options to esptool
Ouss4 opened a new pull request #2965:
URL: https://github.com/apache/incubator-nuttx/pull/2965
## Summary
Adds more flash options to `esptool` for both ESP32 and ESP32-C3.
## Impact
None on any other chips.
## Testing
Building and flashing ESP32 and ESP32-C3 boards.
Autodetecting flash size in ESP32-C3 is disabled by default, next released version of `esptool` will fix this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] yamt commented on a change in pull request #2965: ESP32XX: Add more flash options to esptool
Posted by GitBox <gi...@apache.org>.
yamt commented on a change in pull request #2965:
URL: https://github.com/apache/incubator-nuttx/pull/2965#discussion_r586964104
##########
File path: arch/xtensa/src/esp32/Kconfig
##########
@@ -130,6 +136,39 @@ config ESP32_ESP32DXWDXX
default n
select ESP32_DUAL_CPU
+choice ESP32_FLASH_MODE
Review comment:
how do you think about putting "ESPTOOL" in the names of these things if they only affect esptool options?
with the current name it isn't clear to me if it's for tools or the nuttx binary itself.
probably not in this pr as it affects the existing names like ESP32_FLASH_16M though.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #2965: ESP32XX: Add more flash options to esptool
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #2965:
URL: https://github.com/apache/incubator-nuttx/pull/2965
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org