[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #6952: Minor: Improve aggregate test coverage more

["alamb (via GitHub)" <gi...@apache.org>]

alamb commented on code in PR #6952:
URL: https://github.com/apache/arrow-datafusion/pull/6952#discussion_r1262453491


##########
datafusion/core/tests/sqllogictests/test_files/aggregate.slt:
##########
@@ -1420,65 +1420,95 @@ select var(sq.column1), var_pop(sq.column1), stddev(sq.column1), stddev_pop(sq.c
 2 1 1.414213562373 1
 
 
-# sum / count for all nulls
-statement ok
-create table the_nulls as values (null::bigint, 1), (null::bigint, 1), (null::bigint, 2);
 
-# counts should be zeros (even for nulls)
-query II
-SELECT count(column1), column2 from the_nulls group by column2 order by column2;
+# aggregates on empty tables
+statement ok
+CREATE TABLE empty (column1 bigint, column2 int);
+
+# no group by column

Review Comment:
   The null tests didn't originally have coverage for the no group by case so I added that and consolidated some tests



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org