You are viewing a plain text version of this content. The canonical link for it is here.
Posted to adffaces-dev@incubator.apache.org by Si...@DMR.CA on 2006/08/02 13:12:03 UTC

JSF 1.2 vs. RequestMap, SessionMap, ApplicationMap and AttributeMap

Hello,

Sould I post a trivial priority issue on JIRA about what Trinidad put in 
the following map: RequestMap, SessionMap, ApplicationMap and 
AttributeMap? JSF 1.2 specifies <String, Object> for all of them while 
Trinidad uses <Object, Object>. Since we don't plan to switch to 1.2 soon 
it's not a big deal yet, but I think we should keep it in mind so we know 
some changes will be required to conform to 1.2 spec.


Simon Lessard
Fujitsu Consulting

Re: Re: Re: JSF 1.2 vs. RequestMap, SessionMap, ApplicationMap and AttributeMap

Posted by Adam Winer <aw...@gmail.com>.
maxPathKey sounds like just a bug.

UIXComponentBase shouldn't allow PropertyKeys in its ValueMap;
seemed like a good idea at the time, but I don't think anyone is using
it, and it causes API problems.

-- Adam


On 8/2/06, Simon_Lessard@dmr.ca <Si...@dmr.ca> wrote:
> Errrr,
>
> Actually it's the maxPathKey, that is an object, not the rowKey.
>
> Simon Lessard
> Fujitsu Consulting
>
>
>
>
> Simon_Lessard@DMR.CA
> 2006-08-02 12:55
> Please respond to adffaces-dev
>
>         To:     adffaces-dev@incubator.apache.org
>         cc:
>         Subject:        Re: Re: JSF 1.2 vs. RequestMap, SessionMap,
> ApplicationMap and AttributeMap
>
>
> Hello,
>
> For the attribute map, UIXComponentBase uses a ValueMap class that allows
> String and PropertyKey keys. I didn't find any place using that feature
> yet however.
>
> As for the scope maps, Trinidad does use Object keys when saving some
> DataModel rowkeys information. An example is ProcessUtils.clearMaxPath. An
>
> easy fix would be to change the DataModel to allow only String rowKeys
> since I think all the internal ones already use String only.
>
>
> Regards,
>
> Simon Lessard
> Fujitsu Consulting
>
>
>
>
>
> "Adam Winer" <aw...@gmail.com>
> 2006-08-02 12:05
> Please respond to adffaces-dev
>
>         To:     adffaces-dev@incubator.apache.org
>         cc:
>         Subject:        Re: Re: JSF 1.2 vs. RequestMap, SessionMap,
> ApplicationMap and AttributeMap
>
>
> If Trinidad *is* using any non-String keys, that'd actually
> be a pretty bad bug.  So, I'd definitely like to keep track
> of this.
>
> -- Adam
>
>
> On 8/2/06, Matthias Wessendorf <ma...@apache.org> wrote:
> > Hi Simon,
> >
> > I think it is not a bad idea to keep track of issues like that. As you
> > already notice it's not a blocker but maybe a "major". The earlier we
> > know what needs to be done; the better.
> >
> > -Matthias
> >
> > On 8/2/06, Simon_Lessard@dmr.ca <Si...@dmr.ca> wrote:
> > > Hello,
> > >
> > > Sould I post a trivial priority issue on JIRA about what Trinidad put
> in
> > > the following map: RequestMap, SessionMap, ApplicationMap and
> > > AttributeMap? JSF 1.2 specifies <String, Object> for all of them while
> > > Trinidad uses <Object, Object>. Since we don't plan to switch to 1.2
> soon
> > > it's not a big deal yet, but I think we should keep it in mind so we
> know
> > > some changes will be required to conform to 1.2 spec.
> > >
> > >
> > > Simon Lessard
> > > Fujitsu Consulting
> > >
> >
> >
> > --
> > Matthias Wessendorf
> >
> > further stuff:
> > blog: http://jroller.com/page/mwessendorf
> > mail: mwessendorf-at-gmail-dot-com
> >
>
>
>
>

Re: Re: JSF 1.2 vs. RequestMap, SessionMap, ApplicationMap and AttributeMap

Posted by Si...@DMR.CA.
Errrr,

Actually it's the maxPathKey, that is an object, not the rowKey.

Simon Lessard
Fujitsu Consulting




Simon_Lessard@DMR.CA
2006-08-02 12:55
Please respond to adffaces-dev
 
        To:     adffaces-dev@incubator.apache.org
        cc: 
        Subject:        Re: Re: JSF 1.2 vs. RequestMap, SessionMap, 
ApplicationMap and AttributeMap


Hello,

For the attribute map, UIXComponentBase uses a ValueMap class that allows 
String and PropertyKey keys. I didn't find any place using that feature 
yet however.

As for the scope maps, Trinidad does use Object keys when saving some 
DataModel rowkeys information. An example is ProcessUtils.clearMaxPath. An 

easy fix would be to change the DataModel to allow only String rowKeys 
since I think all the internal ones already use String only.


Regards,

Simon Lessard
Fujitsu Consulting





"Adam Winer" <aw...@gmail.com>
2006-08-02 12:05
Please respond to adffaces-dev
 
        To:     adffaces-dev@incubator.apache.org
        cc: 
        Subject:        Re: Re: JSF 1.2 vs. RequestMap, SessionMap, 
ApplicationMap and AttributeMap


If Trinidad *is* using any non-String keys, that'd actually
be a pretty bad bug.  So, I'd definitely like to keep track
of this.

-- Adam


On 8/2/06, Matthias Wessendorf <ma...@apache.org> wrote:
> Hi Simon,
>
> I think it is not a bad idea to keep track of issues like that. As you
> already notice it's not a blocker but maybe a "major". The earlier we
> know what needs to be done; the better.
>
> -Matthias
>
> On 8/2/06, Simon_Lessard@dmr.ca <Si...@dmr.ca> wrote:
> > Hello,
> >
> > Sould I post a trivial priority issue on JIRA about what Trinidad put 
in
> > the following map: RequestMap, SessionMap, ApplicationMap and
> > AttributeMap? JSF 1.2 specifies <String, Object> for all of them while
> > Trinidad uses <Object, Object>. Since we don't plan to switch to 1.2 
soon
> > it's not a big deal yet, but I think we should keep it in mind so we 
know
> > some changes will be required to conform to 1.2 spec.
> >
> >
> > Simon Lessard
> > Fujitsu Consulting
> >
>
>
> --
> Matthias Wessendorf
>
> further stuff:
> blog: http://jroller.com/page/mwessendorf
> mail: mwessendorf-at-gmail-dot-com
>



Re: Re: JSF 1.2 vs. RequestMap, SessionMap, ApplicationMap and AttributeMap

Posted by Si...@DMR.CA.
Hello,

For the attribute map, UIXComponentBase uses a ValueMap class that allows 
String and PropertyKey keys. I didn't find any place using that feature 
yet however.

As for the scope maps, Trinidad does use Object keys when saving some 
DataModel rowkeys information. An example is ProcessUtils.clearMaxPath. An 
easy fix would be to change the DataModel to allow only String rowKeys 
since I think all the internal ones already use String only.


Regards,

Simon Lessard
Fujitsu Consulting





"Adam Winer" <aw...@gmail.com>
2006-08-02 12:05
Please respond to adffaces-dev
 
        To:     adffaces-dev@incubator.apache.org
        cc: 
        Subject:        Re: Re: JSF 1.2 vs. RequestMap, SessionMap, 
ApplicationMap and AttributeMap


If Trinidad *is* using any non-String keys, that'd actually
be a pretty bad bug.  So, I'd definitely like to keep track
of this.

-- Adam


On 8/2/06, Matthias Wessendorf <ma...@apache.org> wrote:
> Hi Simon,
>
> I think it is not a bad idea to keep track of issues like that. As you
> already notice it's not a blocker but maybe a "major". The earlier we
> know what needs to be done; the better.
>
> -Matthias
>
> On 8/2/06, Simon_Lessard@dmr.ca <Si...@dmr.ca> wrote:
> > Hello,
> >
> > Sould I post a trivial priority issue on JIRA about what Trinidad put 
in
> > the following map: RequestMap, SessionMap, ApplicationMap and
> > AttributeMap? JSF 1.2 specifies <String, Object> for all of them while
> > Trinidad uses <Object, Object>. Since we don't plan to switch to 1.2 
soon
> > it's not a big deal yet, but I think we should keep it in mind so we 
know
> > some changes will be required to conform to 1.2 spec.
> >
> >
> > Simon Lessard
> > Fujitsu Consulting
> >
>
>
> --
> Matthias Wessendorf
>
> further stuff:
> blog: http://jroller.com/page/mwessendorf
> mail: mwessendorf-at-gmail-dot-com
>


Re: Re: JSF 1.2 vs. RequestMap, SessionMap, ApplicationMap and AttributeMap

Posted by Adam Winer <aw...@gmail.com>.
If Trinidad *is* using any non-String keys, that'd actually
be a pretty bad bug.  So, I'd definitely like to keep track
of this.

-- Adam


On 8/2/06, Matthias Wessendorf <ma...@apache.org> wrote:
> Hi Simon,
>
> I think it is not a bad idea to keep track of issues like that. As you
> already notice it's not a blocker but maybe a "major". The earlier we
> know what needs to be done; the better.
>
> -Matthias
>
> On 8/2/06, Simon_Lessard@dmr.ca <Si...@dmr.ca> wrote:
> > Hello,
> >
> > Sould I post a trivial priority issue on JIRA about what Trinidad put in
> > the following map: RequestMap, SessionMap, ApplicationMap and
> > AttributeMap? JSF 1.2 specifies <String, Object> for all of them while
> > Trinidad uses <Object, Object>. Since we don't plan to switch to 1.2 soon
> > it's not a big deal yet, but I think we should keep it in mind so we know
> > some changes will be required to conform to 1.2 spec.
> >
> >
> > Simon Lessard
> > Fujitsu Consulting
> >
>
>
> --
> Matthias Wessendorf
>
> further stuff:
> blog: http://jroller.com/page/mwessendorf
> mail: mwessendorf-at-gmail-dot-com
>

Re: JSF 1.2 vs. RequestMap, SessionMap, ApplicationMap and AttributeMap

Posted by Matthias Wessendorf <ma...@apache.org>.
Hi Simon,

I think it is not a bad idea to keep track of issues like that. As you
already notice it's not a blocker but maybe a "major". The earlier we
know what needs to be done; the better.

-Matthias

On 8/2/06, Simon_Lessard@dmr.ca <Si...@dmr.ca> wrote:
> Hello,
>
> Sould I post a trivial priority issue on JIRA about what Trinidad put in
> the following map: RequestMap, SessionMap, ApplicationMap and
> AttributeMap? JSF 1.2 specifies <String, Object> for all of them while
> Trinidad uses <Object, Object>. Since we don't plan to switch to 1.2 soon
> it's not a big deal yet, but I think we should keep it in mind so we know
> some changes will be required to conform to 1.2 spec.
>
>
> Simon Lessard
> Fujitsu Consulting
>


-- 
Matthias Wessendorf

further stuff:
blog: http://jroller.com/page/mwessendorf
mail: mwessendorf-at-gmail-dot-com