[GitHub] [spark] MaxGekk commented on a diff in pull request #40641: [SPARK-43011][SQL] `array_insert` should fail with 0 index

["MaxGekk (via GitHub)" <gi...@apache.org>]

MaxGekk commented on code in PR #40641:
URL: https://github.com/apache/spark/pull/40641#discussion_r1156308161


##########
core/src/main/resources/error/error-classes.json:
##########
@@ -536,7 +536,7 @@
     ],
     "sqlState" : "23505"
   },
-  "ELEMENT_AT_BY_INDEX_ZERO" : {
+  "INVALID_INDEX_OF_ZERO" : {

Review Comment:
   Highly likely, it should be moved since error classes must be sorted in the file.



##########
docs/sql-error-conditions.md:
##########
@@ -289,7 +289,7 @@ Duplicate map key `<key>` was found, please check the input data. If you want to
 
 Found duplicate keys `<keyColumn>`.
 
-### ELEMENT_AT_BY_INDEX_ZERO
+### INVALID_INDEX_OF_ZERO

Review Comment:
   Could you move it according to alphabetical sorting, please.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org