You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Dmytro Sen <ds...@hortonworks.com> on 2014/12/11 18:07:01 UTC
Review Request 28948: Incorrect / Missing metrics data
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28948/
-----------------------------------------------------------
Review request for Ambari, Myroslav Papirkovskyy and Sid Wagle.
Bugs: AMBARI-8662
https://issues.apache.org/jira/browse/AMBARI-8662
Repository: ambari
Description
-------
looks like cpu metrics are still incremental instead of avg
Missing disk usage on hosts page.
Missing yarn graphs
Diffs
-----
ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/host_info.py 5bc4afb
ambari-metrics/ambari-metrics-host-monitoring/src/test/python/core/TestHostInfo.py 757edbe
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/HBaseTimelineMetricStore.java 9364187
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/PhoenixHBaseAccessor.java cb28a8b
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/PhoenixTransactSQL.java 93ba2d8
ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TestPhoenixTransactSQL.java 758f5a9
ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/AMSPropertyProvider.java 50eb08e
ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/templates/hadoop-metrics2.properties.j2 d7a66ab
ambari-server/src/test/java/org/apache/ambari/server/controller/metrics/timeline/AMSPropertyProviderTest.java 82f9aff
ambari-server/src/test/resources/ams/multiple_component_regexp_metrics.json PRE-CREATION
Diff: https://reviews.apache.org/r/28948/diff/
Testing
-------
tests passed
Thanks,
Dmytro Sen
Re: Review Request 28948: Incorrect / Missing metrics data
Posted by Sid Wagle <sw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28948/#review64748
-----------------------------------------------------------
Ship it!
Ship It!
- Sid Wagle
On Dec. 11, 2014, 5:07 p.m., Dmytro Sen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28948/
> -----------------------------------------------------------
>
> (Updated Dec. 11, 2014, 5:07 p.m.)
>
>
> Review request for Ambari, Myroslav Papirkovskyy and Sid Wagle.
>
>
> Bugs: AMBARI-8662
> https://issues.apache.org/jira/browse/AMBARI-8662
>
>
> Repository: ambari
>
>
> Description
> -------
>
> looks like cpu metrics are still incremental instead of avg
> Missing disk usage on hosts page.
> Missing yarn graphs
>
>
> Diffs
> -----
>
> ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/host_info.py 5bc4afb
> ambari-metrics/ambari-metrics-host-monitoring/src/test/python/core/TestHostInfo.py 757edbe
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/HBaseTimelineMetricStore.java 9364187
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/PhoenixHBaseAccessor.java cb28a8b
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/PhoenixTransactSQL.java 93ba2d8
> ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TestPhoenixTransactSQL.java 758f5a9
> ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/AMSPropertyProvider.java 50eb08e
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/templates/hadoop-metrics2.properties.j2 d7a66ab
> ambari-server/src/test/java/org/apache/ambari/server/controller/metrics/timeline/AMSPropertyProviderTest.java 82f9aff
> ambari-server/src/test/resources/ams/multiple_component_regexp_metrics.json PRE-CREATION
>
> Diff: https://reviews.apache.org/r/28948/diff/
>
>
> Testing
> -------
>
> tests passed
>
>
> Thanks,
>
> Dmytro Sen
>
>
Re: Review Request 28948: Incorrect / Missing metrics data
Posted by Myroslav Papirkovskyy <mp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28948/#review64749
-----------------------------------------------------------
Ship it!
Ship It!
- Myroslav Papirkovskyy
On Гру. 11, 2014, 7:07 після полудня, Dmytro Sen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28948/
> -----------------------------------------------------------
>
> (Updated Гру. 11, 2014, 7:07 після полудня)
>
>
> Review request for Ambari, Myroslav Papirkovskyy and Sid Wagle.
>
>
> Bugs: AMBARI-8662
> https://issues.apache.org/jira/browse/AMBARI-8662
>
>
> Repository: ambari
>
>
> Description
> -------
>
> looks like cpu metrics are still incremental instead of avg
> Missing disk usage on hosts page.
> Missing yarn graphs
>
>
> Diffs
> -----
>
> ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/host_info.py 5bc4afb
> ambari-metrics/ambari-metrics-host-monitoring/src/test/python/core/TestHostInfo.py 757edbe
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/HBaseTimelineMetricStore.java 9364187
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/PhoenixHBaseAccessor.java cb28a8b
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/PhoenixTransactSQL.java 93ba2d8
> ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TestPhoenixTransactSQL.java 758f5a9
> ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/AMSPropertyProvider.java 50eb08e
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/templates/hadoop-metrics2.properties.j2 d7a66ab
> ambari-server/src/test/java/org/apache/ambari/server/controller/metrics/timeline/AMSPropertyProviderTest.java 82f9aff
> ambari-server/src/test/resources/ams/multiple_component_regexp_metrics.json PRE-CREATION
>
> Diff: https://reviews.apache.org/r/28948/diff/
>
>
> Testing
> -------
>
> tests passed
>
>
> Thanks,
>
> Dmytro Sen
>
>