[GitHub] spark pull request #13915: [SPARK-16081][BUILD] Disallow using `l` as variab...

[srowen <gi...@git.apache.org>]

Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/13915#discussion_r68534110
  
    --- Diff: core/src/main/scala/org/apache/spark/api/python/PythonHadoopUtil.scala ---
    @@ -122,7 +122,7 @@ private[python] class JavaToWritableConverter extends Converter[Any, Writable] {
         obj match {
           case i: java.lang.Integer => new IntWritable(i)
           case d: java.lang.Double => new DoubleWritable(d)
    -      case l: java.lang.Long => new LongWritable(l)
    +      case v: java.lang.Long => new LongWritable(v)
    --- End diff --
    
    Hm, tough one. I understand the logic behind avoiding `l` because it looks like `1`. Here, it feels OK to use `l` though. `v` suggests `void` here, another primitive type. Maybe `n`? not sure. I'd argue we could leave instances like this alone, though then we have to remove the style rule.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org