[GitHub] [trafficserver] ywkaras commented on a diff in pull request #10141: Fix dl_load_lock and DbgCtl deadlock

["ywkaras (via GitHub)" <gi...@apache.org>]

ywkaras commented on code in PR #10141:
URL: https://github.com/apache/trafficserver/pull/10141#discussion_r1282423166


##########
src/tscore/DbgCtl.cc:
##########
@@ -129,6 +129,7 @@ DbgCtl::_new_reference(char const *tag)
   TSDbgCtl ctl;
 
   ctl.tag = tag;
+  ctl.on  = diags() && diags()->tag_activated(tag, DiagsTagType_Debug);

Review Comment:
   If you set "on" without the Registry mutex locked, there's a race condition, at least hypothetically.  It may not get updated for a change to the regex tags are matched to, to see if they are on.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org