[jira] [Commented] (IGNITE-7701) SQL system view for node attributes

["Vladimir Ozerov (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/IGNITE-7701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16578274#comment-16578274 ] 

Vladimir Ozerov commented on IGNITE-7701:
-----------------------------------------

[~alex_pl], in general implementation looks ok, but I do not think we need {{IgniteParentChildIterator}}, as it looks too complex for the task we need solve.
Please have a look at {{GridFunc.concant(Iterator...}} method - it already combines multiple iterators into one. Can we just open iterators to attribute of all nodes and then combine them into a single iterator? 
Another possible source of complexity is {{org.apache.ignite.internal.processors.query.h2.sys.view.SqlSystemView#getRows}} - we return {{Iterable}}, only to call {{iterator()}} in the next instruction. Can we just return {{Iterator}} instead and thus remove one more unnecessary wrapper?

> SQL system view for node attributes
> -----------------------------------
>
>                 Key: IGNITE-7701
>                 URL: https://issues.apache.org/jira/browse/IGNITE-7701
>             Project: Ignite
>          Issue Type: Task
>          Components: sql
>            Reporter: Aleksey Plekhanov
>            Assignee: Aleksey Plekhanov
>            Priority: Major
>              Labels: iep-13, sql
>             Fix For: 2.7
>
>
> Implement SQL system view to show attributes for each node in topology.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)