You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kudu.apache.org by ba...@apache.org on 2021/02/10 23:17:30 UTC
[kudu] branch master updated: [build] KUDU-3243 Fix cmake warnings
This is an automated email from the ASF dual-hosted git repository.
bankim pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/kudu.git
The following commit(s) were added to refs/heads/master by this push:
new 9acdc52 [build] KUDU-3243 Fix cmake warnings
9acdc52 is described below
commit 9acdc525c6816ab83ad71f25220c428792fe36ad
Author: Bankim Bhavsar <ba...@cloudera.com>
AuthorDate: Wed Feb 10 13:57:09 2021 -0800
[build] KUDU-3243 Fix cmake warnings
Bunch of warnings while running cmake of the following form:
CMake Warning (dev) at
cmake-3.19/Modules/FindPackageHandleStandardArgs.cmake:272 (message):
The package name passed to `find_package_handle_standard_args`
(GUMBO_PARSER) does not match the name of the calling package
(GumboParser). This can lead to problems in calling code that expects
`find_package` result variables (e.g., `_FOUND`) to follow a certain
pattern.
Call Stack (most recent call first):
cmake_modules/FindGumboParser.cmake:40 (find_package_handle_standard_args)
CMakeLists.txt:1205 (find_package)
This warning is for project developers. Use -Wno-dev to suppress it.
There is mismatch in case/naming of the packages specified in
CMakeLists.txt at the base kudu directory and the name of the
package set under individual cmake module under cmake_modules.
No functional change. Verified no cmake warnings of the form
specified above.
Change-Id: I45ad38cf16f9ec6e23eb18e849ff5a3df3ea6ddd
Reviewed-on: http://gerrit.cloudera.org:8080/17057
Reviewed-by: Alexey Serbin <as...@cloudera.com>
Tested-by: Bankim Bhavsar <ba...@cloudera.com>
---
cmake_modules/FindBitshuffle.cmake | 2 +-
cmake_modules/FindBreakpadClient.cmake | 2 +-
cmake_modules/FindCrcutil.cmake | 2 +-
cmake_modules/FindCyrusSASL.cmake | 2 +-
cmake_modules/FindGFlags.cmake | 2 +-
cmake_modules/FindGLog.cmake | 2 +-
cmake_modules/FindGMock.cmake | 2 +-
cmake_modules/FindGPerf.cmake | 2 +-
cmake_modules/FindGSSAPI.cmake | 2 +-
cmake_modules/FindGumboParser.cmake | 2 +-
cmake_modules/FindGumboQuery.cmake | 2 +-
cmake_modules/FindKerberos.cmake | 2 +-
cmake_modules/FindKerberosPrograms.cmake | 2 +-
cmake_modules/FindKuduBoost.cmake | 2 +-
cmake_modules/FindLibEv.cmake | 2 +-
cmake_modules/FindLibUnwind.cmake | 2 +-
cmake_modules/FindLz4.cmake | 2 +-
cmake_modules/FindMustache.cmake | 2 +-
cmake_modules/FindProtobuf.cmake | 2 +-
cmake_modules/FindSnappy.cmake | 2 +-
cmake_modules/FindSqueasel.cmake | 2 +-
cmake_modules/FindThrift.cmake | 2 +-
cmake_modules/FindYaml.cmake | 2 +-
cmake_modules/FindZlib.cmake | 2 +-
24 files changed, 24 insertions(+), 24 deletions(-)
diff --git a/cmake_modules/FindBitshuffle.cmake b/cmake_modules/FindBitshuffle.cmake
index 8caae64..942bc35 100644
--- a/cmake_modules/FindBitshuffle.cmake
+++ b/cmake_modules/FindBitshuffle.cmake
@@ -31,5 +31,5 @@ find_library(BITSHUFFLE_STATIC_LIB bitshuffle.a
NO_SYSTEM_ENVIRONMENT_PATH)
include(FindPackageHandleStandardArgs)
-find_package_handle_standard_args(BITSHUFFLE REQUIRED_VARS
+find_package_handle_standard_args(Bitshuffle REQUIRED_VARS
BITSHUFFLE_STATIC_LIB BITSHUFFLE_INCLUDE_DIR)
diff --git a/cmake_modules/FindBreakpadClient.cmake b/cmake_modules/FindBreakpadClient.cmake
index b79db5c..c4cc563 100644
--- a/cmake_modules/FindBreakpadClient.cmake
+++ b/cmake_modules/FindBreakpadClient.cmake
@@ -32,5 +32,5 @@ find_library(BREAKPAD_CLIENT_SHARED_LIB breakpad_client
NO_SYSTEM_ENVIRONMENT_PATH)
include(FindPackageHandleStandardArgs)
-find_package_handle_standard_args(BREAKPAD_CLIENT REQUIRED_VARS
+find_package_handle_standard_args(BreakpadClient REQUIRED_VARS
BREAKPAD_CLIENT_SHARED_LIB BREAKPAD_CLIENT_STATIC_LIB BREAKPAD_CLIENT_INCLUDE_DIR)
diff --git a/cmake_modules/FindCrcutil.cmake b/cmake_modules/FindCrcutil.cmake
index 6866348..3ed1f09 100644
--- a/cmake_modules/FindCrcutil.cmake
+++ b/cmake_modules/FindCrcutil.cmake
@@ -33,5 +33,5 @@ find_library(CRCUTIL_STATIC_LIB libcrcutil.a
NO_SYSTEM_ENVIRONMENT_PATH)
include(FindPackageHandleStandardArgs)
-find_package_handle_standard_args(CRCUTIL REQUIRED_VARS
+find_package_handle_standard_args(Crcutil REQUIRED_VARS
CRCUTIL_SHARED_LIB CRCUTIL_STATIC_LIB CRCUTIL_INCLUDE_DIR)
diff --git a/cmake_modules/FindCyrusSASL.cmake b/cmake_modules/FindCyrusSASL.cmake
index 24192b7..e6a94b0 100644
--- a/cmake_modules/FindCyrusSASL.cmake
+++ b/cmake_modules/FindCyrusSASL.cmake
@@ -38,5 +38,5 @@ find_path(CYRUS_SASL_INCLUDE_DIR sasl/sasl.h)
find_library(CYRUS_SASL_SHARED_LIB sasl2)
include(FindPackageHandleStandardArgs)
-find_package_handle_standard_args(CYRUS_SASL REQUIRED_VARS
+find_package_handle_standard_args(CyrusSASL REQUIRED_VARS
CYRUS_SASL_SHARED_LIB CYRUS_SASL_INCLUDE_DIR)
diff --git a/cmake_modules/FindGFlags.cmake b/cmake_modules/FindGFlags.cmake
index acfbccd..db1d4fc 100644
--- a/cmake_modules/FindGFlags.cmake
+++ b/cmake_modules/FindGFlags.cmake
@@ -34,5 +34,5 @@ find_library(GFLAGS_STATIC_LIB libgflags.a
NO_SYSTEM_ENVIRONMENT_PATH)
include(FindPackageHandleStandardArgs)
-find_package_handle_standard_args(GFLAGS REQUIRED_VARS
+find_package_handle_standard_args(GFlags REQUIRED_VARS
GFLAGS_SHARED_LIB GFLAGS_STATIC_LIB GFLAGS_INCLUDE_DIR)
diff --git a/cmake_modules/FindGLog.cmake b/cmake_modules/FindGLog.cmake
index c9876b7..cd7914a 100644
--- a/cmake_modules/FindGLog.cmake
+++ b/cmake_modules/FindGLog.cmake
@@ -34,5 +34,5 @@ find_library(GLOG_STATIC_LIB libglog.a
NO_SYSTEM_ENVIRONMENT_PATH)
include(FindPackageHandleStandardArgs)
-find_package_handle_standard_args(GLOG REQUIRED_VARS
+find_package_handle_standard_args(GLog REQUIRED_VARS
GLOG_SHARED_LIB GLOG_STATIC_LIB GLOG_INCLUDE_DIR)
diff --git a/cmake_modules/FindGMock.cmake b/cmake_modules/FindGMock.cmake
index 7b6eb70..48f8997 100644
--- a/cmake_modules/FindGMock.cmake
+++ b/cmake_modules/FindGMock.cmake
@@ -53,5 +53,5 @@ find_library(GMOCK_STATIC_LIBRARY libgmock.a
include(FindPackageHandleStandardArgs)
-find_package_handle_standard_args(GMOCK REQUIRED_VARS
+find_package_handle_standard_args(GMock REQUIRED_VARS
GMOCK_SHARED_LIBRARY GMOCK_STATIC_LIBRARY GMOCK_INCLUDE_DIR GTEST_INCLUDE_DIR)
diff --git a/cmake_modules/FindGPerf.cmake b/cmake_modules/FindGPerf.cmake
index d3ed697..571dc5d 100644
--- a/cmake_modules/FindGPerf.cmake
+++ b/cmake_modules/FindGPerf.cmake
@@ -45,7 +45,7 @@ FIND_LIBRARY(PROFILER_STATIC_LIB libprofiler.a
NO_SYSTEM_ENVIRONMENT_PATH)
include(FindPackageHandleStandardArgs)
-find_package_handle_standard_args(GOOGLE_PERFTOOLS REQUIRED_VARS
+find_package_handle_standard_args(GPerf REQUIRED_VARS
TCMALLOC_SHARED_LIB TCMALLOC_STATIC_LIB
PROFILER_SHARED_LIB PROFILER_STATIC_LIB
GOOGLE_PERFTOOLS_INCLUDE_DIR)
diff --git a/cmake_modules/FindGSSAPI.cmake b/cmake_modules/FindGSSAPI.cmake
index 19c0691..8d7288c 100644
--- a/cmake_modules/FindGSSAPI.cmake
+++ b/cmake_modules/FindGSSAPI.cmake
@@ -30,5 +30,5 @@ find_path(GSSAPI_INCLUDE_DIR gssapi/gssapi.h)
find_library(GSSAPI_SHARED_LIB gssapi_krb5)
include(FindPackageHandleStandardArgs)
-find_package_handle_standard_args(GSSAPI_VARS
+find_package_handle_standard_args(GSSAPI
GSSAPI_SHARED_LIB GSSAPI_INCLUDE_DIR)
diff --git a/cmake_modules/FindGumboParser.cmake b/cmake_modules/FindGumboParser.cmake
index 0cdda17..24a18fe 100644
--- a/cmake_modules/FindGumboParser.cmake
+++ b/cmake_modules/FindGumboParser.cmake
@@ -37,5 +37,5 @@ set(CMAKE_FIND_LIBRARY_SUFFIXES ${__CURRENT_FIND_LIBRARY_SUFFIXES})
unset(__CURRENT_FIND_LIBRARY_SUFFIXES)
include(FindPackageHandleStandardArgs)
-find_package_handle_standard_args(GUMBO_PARSER REQUIRED_VARS
+find_package_handle_standard_args(GumboParser REQUIRED_VARS
GUMBO_PARSER_STATIC_LIB GUMBO_PARSER_SHARED_LIB GUMBO_PARSER_INCLUDE_DIR)
diff --git a/cmake_modules/FindGumboQuery.cmake b/cmake_modules/FindGumboQuery.cmake
index edee4f7..dca7e11 100644
--- a/cmake_modules/FindGumboQuery.cmake
+++ b/cmake_modules/FindGumboQuery.cmake
@@ -37,5 +37,5 @@ set(CMAKE_FIND_LIBRARY_SUFFIXES ${__CURRENT_FIND_LIBRARY_SUFFIXES})
unset(__CURRENT_FIND_LIBRARY_SUFFIXES)
include(FindPackageHandleStandardArgs)
-find_package_handle_standard_args(GUMBO_QUERY REQUIRED_VARS
+find_package_handle_standard_args(GumboQuery REQUIRED_VARS
GUMBO_QUERY_STATIC_LIB GUMBO_QUERY_SHARED_LIB GUMBO_QUERY_INCLUDE_DIR)
diff --git a/cmake_modules/FindKerberos.cmake b/cmake_modules/FindKerberos.cmake
index 197a30c..5baa4fd 100644
--- a/cmake_modules/FindKerberos.cmake
+++ b/cmake_modules/FindKerberos.cmake
@@ -27,4 +27,4 @@ find_library(KERBEROS_LIBRARY NAMES krb5)
# handle the QUIETLY and REQUIRED arguments and set KERBEROS_FOUND to TRUE if
# all listed variables are TRUE
include(FindPackageHandleStandardArgs)
-find_package_handle_standard_args(KERBEROS DEFAULT_MSG KERBEROS_LIBRARY KERBEROS_INCLUDE_DIR)
+find_package_handle_standard_args(Kerberos DEFAULT_MSG KERBEROS_LIBRARY KERBEROS_INCLUDE_DIR)
diff --git a/cmake_modules/FindKerberosPrograms.cmake b/cmake_modules/FindKerberosPrograms.cmake
index 27b181a..f5c0b3f 100644
--- a/cmake_modules/FindKerberosPrograms.cmake
+++ b/cmake_modules/FindKerberosPrograms.cmake
@@ -34,5 +34,5 @@ foreach(bin ${bins})
/usr/lib/mit/sbin)
endforeach(bin)
-find_package_handle_standard_args(Kerberos REQUIRED_VARS ${bins}
+find_package_handle_standard_args(KerberosPrograms REQUIRED_VARS ${bins}
FAIL_MESSAGE "Kerberos binaries not found: security tests will fail")
diff --git a/cmake_modules/FindKuduBoost.cmake b/cmake_modules/FindKuduBoost.cmake
index 3b1cea4..7b120c9 100644
--- a/cmake_modules/FindKuduBoost.cmake
+++ b/cmake_modules/FindKuduBoost.cmake
@@ -42,5 +42,5 @@ find_library(BOOST_DATE_TIME_STATIC_LIB libboost_date_time.a
NO_SYSTEM_ENVIRONMENT_PATH)
include(FindPackageHandleStandardArgs)
-find_package_handle_standard_args(BOOST_DATE_TIME REQUIRED_VARS
+find_package_handle_standard_args(KuduBoost REQUIRED_VARS
BOOST_DATE_TIME_SHARED_LIB BOOST_DATE_TIME_STATIC_LIB BOOST_INCLUDE_DIR)
\ No newline at end of file
diff --git a/cmake_modules/FindLibEv.cmake b/cmake_modules/FindLibEv.cmake
index c2cfbd3..6edb014 100644
--- a/cmake_modules/FindLibEv.cmake
+++ b/cmake_modules/FindLibEv.cmake
@@ -34,5 +34,5 @@ find_library(LIBEV_STATIC_LIB libev.a
NO_SYSTEM_ENVIRONMENT_PATH)
include(FindPackageHandleStandardArgs)
-find_package_handle_standard_args(LIBEV REQUIRED_VARS
+find_package_handle_standard_args(LibEv REQUIRED_VARS
LIBEV_SHARED_LIB LIBEV_STATIC_LIB LIBEV_INCLUDE_DIR)
diff --git a/cmake_modules/FindLibUnwind.cmake b/cmake_modules/FindLibUnwind.cmake
index b6a8622..0fbe129 100644
--- a/cmake_modules/FindLibUnwind.cmake
+++ b/cmake_modules/FindLibUnwind.cmake
@@ -33,5 +33,5 @@ find_library(UNWIND_STATIC_LIB libunwind.a
NO_SYSTEM_ENVIRONMENT_PATH)
include(FindPackageHandleStandardArgs)
-find_package_handle_standard_args(UNWIND REQUIRED_VARS
+find_package_handle_standard_args(LibUnwind REQUIRED_VARS
UNWIND_SHARED_LIB UNWIND_STATIC_LIB UNWIND_INCLUDE_DIR)
diff --git a/cmake_modules/FindLz4.cmake b/cmake_modules/FindLz4.cmake
index 362d493..0c5c5a7 100644
--- a/cmake_modules/FindLz4.cmake
+++ b/cmake_modules/FindLz4.cmake
@@ -30,5 +30,5 @@ find_library(LZ4_STATIC_LIB liblz4.a
NO_SYSTEM_ENVIRONMENT_PATH)
include(FindPackageHandleStandardArgs)
-find_package_handle_standard_args(LZ4 REQUIRED_VARS
+find_package_handle_standard_args(Lz4 REQUIRED_VARS
LZ4_STATIC_LIB LZ4_INCLUDE_DIR)
diff --git a/cmake_modules/FindMustache.cmake b/cmake_modules/FindMustache.cmake
index e1e38f7..9a91299 100644
--- a/cmake_modules/FindMustache.cmake
+++ b/cmake_modules/FindMustache.cmake
@@ -30,5 +30,5 @@ find_library(MUSTACHE_STATIC_LIB libmustache.a
NO_SYSTEM_ENVIRONMENT_PATH)
include(FindPackageHandleStandardArgs)
-find_package_handle_standard_args(MUSTACHE REQUIRED_VARS
+find_package_handle_standard_args(Mustache REQUIRED_VARS
MUSTACHE_STATIC_LIB MUSTACHE_INCLUDE_DIR)
diff --git a/cmake_modules/FindProtobuf.cmake b/cmake_modules/FindProtobuf.cmake
index 08332ea..231513c 100644
--- a/cmake_modules/FindProtobuf.cmake
+++ b/cmake_modules/FindProtobuf.cmake
@@ -224,7 +224,7 @@ find_program(PROTOBUF_PROTOC_EXECUTABLE protoc
NO_SYSTEM_ENVIRONMENT_PATH)
include(FindPackageHandleStandardArgs)
-find_package_handle_standard_args(PROTOBUF REQUIRED_VARS
+find_package_handle_standard_args(Protobuf REQUIRED_VARS
PROTOBUF_SHARED_LIBRARY PROTOBUF_STATIC_LIBRARY
PROTOBUF_PROTOC_SHARED_LIBRARY PROTOBUF_PROTOC_STATIC_LIBRARY
PROTOBUF_INCLUDE_DIR PROTOBUF_PROTOC_EXECUTABLE)
diff --git a/cmake_modules/FindSnappy.cmake b/cmake_modules/FindSnappy.cmake
index 20d5ace..239b7c9 100644
--- a/cmake_modules/FindSnappy.cmake
+++ b/cmake_modules/FindSnappy.cmake
@@ -34,5 +34,5 @@ find_library(SNAPPY_STATIC_LIB libsnappy.a
NO_SYSTEM_ENVIRONMENT_PATH)
include(FindPackageHandleStandardArgs)
-find_package_handle_standard_args(SNAPPY REQUIRED_VARS
+find_package_handle_standard_args(Snappy REQUIRED_VARS
SNAPPY_SHARED_LIB SNAPPY_STATIC_LIB SNAPPY_INCLUDE_DIR)
diff --git a/cmake_modules/FindSqueasel.cmake b/cmake_modules/FindSqueasel.cmake
index 631a4bf..56f740e 100644
--- a/cmake_modules/FindSqueasel.cmake
+++ b/cmake_modules/FindSqueasel.cmake
@@ -30,5 +30,5 @@ find_library(SQUEASEL_STATIC_LIB libsqueasel.a
NO_SYSTEM_ENVIRONMENT_PATH)
include(FindPackageHandleStandardArgs)
-find_package_handle_standard_args(SQUEASEL REQUIRED_VARS
+find_package_handle_standard_args(Squeasel REQUIRED_VARS
SQUEASEL_STATIC_LIB SQUEASEL_INCLUDE_DIR)
diff --git a/cmake_modules/FindThrift.cmake b/cmake_modules/FindThrift.cmake
index 3b9b217..184e95b 100644
--- a/cmake_modules/FindThrift.cmake
+++ b/cmake_modules/FindThrift.cmake
@@ -162,6 +162,6 @@ find_program(THRIFT_EXECUTABLE thrift
NO_SYSTEM_ENVIRONMENT_PATH)
include(FindPackageHandleStandardArgs)
-find_package_handle_standard_args(THRIFT REQUIRED_VARS
+find_package_handle_standard_args(Thrift REQUIRED_VARS
THRIFT_SHARED_LIBRARY THRIFT_STATIC_LIBRARY
THRIFT_INCLUDE_DIR THRIFT_EXECUTABLE)
diff --git a/cmake_modules/FindYaml.cmake b/cmake_modules/FindYaml.cmake
index 298d4df..d8938e2 100644
--- a/cmake_modules/FindYaml.cmake
+++ b/cmake_modules/FindYaml.cmake
@@ -37,5 +37,5 @@ set(CMAKE_FIND_LIBRARY_SUFFIXES ${__CURRENT_FIND_LIBRARY_SUFFIXES})
unset(__CURRENT_FIND_LIBRARY_SUFFIXES)
include(FindPackageHandleStandardArgs)
-find_package_handle_standard_args(YAML REQUIRED_VARS
+find_package_handle_standard_args(Yaml REQUIRED_VARS
YAML_STATIC_LIB YAML_SHARED_LIB YAML_INCLUDE_DIR)
diff --git a/cmake_modules/FindZlib.cmake b/cmake_modules/FindZlib.cmake
index 48d7b01..870d8e0 100644
--- a/cmake_modules/FindZlib.cmake
+++ b/cmake_modules/FindZlib.cmake
@@ -34,5 +34,5 @@ find_library(ZLIB_STATIC_LIB libz.a
NO_SYSTEM_ENVIRONMENT_PATH)
include(FindPackageHandleStandardArgs)
-find_package_handle_standard_args(ZLIB REQUIRED_VARS
+find_package_handle_standard_args(Zlib REQUIRED_VARS
ZLIB_SHARED_LIB ZLIB_STATIC_LIB ZLIB_INCLUDE_DIR)