You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@royale.apache.org by ca...@apache.org on 2019/01/03 03:02:09 UTC

[royale-asjs] branch develop updated: clean code Jewel CheckBox

This is an automated email from the ASF dual-hosted git repository.

carlosrovira pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/royale-asjs.git


The following commit(s) were added to refs/heads/develop by this push:
     new 62f5782  clean code Jewel CheckBox
62f5782 is described below

commit 62f578248b591998796a6d6e3211abc9c1ae4af8
Author: Carlos Rovira <ca...@apache.org>
AuthorDate: Thu Jan 3 04:02:01 2019 +0100

    clean code Jewel CheckBox
---
 .../royale/TourDeJewel/src/main/royale/ListPlayGround.mxml    |  2 +-
 .../Jewel/src/main/royale/org/apache/royale/jewel/CheckBox.as | 11 +----------
 2 files changed, 2 insertions(+), 11 deletions(-)

diff --git a/examples/royale/TourDeJewel/src/main/royale/ListPlayGround.mxml b/examples/royale/TourDeJewel/src/main/royale/ListPlayGround.mxml
index 4073aab..e9fd924 100644
--- a/examples/royale/TourDeJewel/src/main/royale/ListPlayGround.mxml
+++ b/examples/royale/TourDeJewel/src/main/royale/ListPlayGround.mxml
@@ -172,7 +172,7 @@ limitations under the License.
 							<j:beads>
 								<j:TextPrompt prompt="filter list..."/>
 								<j:SearchFilterForList list="{iconList}"/>
-													<!-- property="label" defaults to label so it's not needed -->
+													<!-- filterProperty="label" defaults to label so it's not needed -->
 							</j:beads>
 						</j:TextInput>
 						<!-- example below for dataProvider binding -->
diff --git a/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/CheckBox.as b/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/CheckBox.as
index e0b310d..656645e 100644
--- a/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/CheckBox.as
+++ b/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/CheckBox.as
@@ -352,16 +352,7 @@ package org.apache.royale.jewel
 			{
                 if(input.checked == value)
                     return;
-                var instance:Object = element['JewelCheckbox'];
-                if(instance)
-                {
-                    if(value)
-                        instance["check"]();
-                    else
-                        instance["uncheck"]();
-                }
-                else
-                    input.checked = value;
+                input.checked = value;
                 dispatchEvent(new Event(Event.CHANGE));
             }
         }