You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@metamodel.apache.org by we...@googlemail.com on 2015/01/17 01:59:30 UTC
Review Request 29995: Fix of not working distinct select for
PojoDataContext (and proabably others, too)
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29995/
-----------------------------------------------------------
Review request for MetaModel.
Bugs: METAMODEL-78
https://issues.apache.org/jira/browse/METAMODEL-78
Repository: metamodel
Description
-------
Proposed fix for issue METAMODEL-78
Diffs
-----
core/src/main/java/org/apache/metamodel/QueryPostprocessDataContext.java ab2dd71
pojo/src/test/java/org/apache/metamodel/pojo/PojoDataContextTest.java e345a8c
Diff: https://reviews.apache.org/r/29995/diff/
Testing
-------
Added two tests to scenario in PojoDataContextTest-Unittest
Thanks,
fwelz
Re: Review Request 29995: METAMODEL-78: Fix of not working distinct
select for PojoDataContext (and proabably others, too)
Posted by Kasper Sørensen <i....@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29995/#review68552
-----------------------------------------------------------
Ship it!
Looks like a simple and good fix to me. The whitespace-related comments are really minor and if needed I guess the committer could just remove those.
pojo/src/test/java/org/apache/metamodel/pojo/PojoDataContextTest.java
<https://reviews.apache.org/r/29995/#comment112854>
Strange whitespaces before the line break?
pojo/src/test/java/org/apache/metamodel/pojo/PojoDataContextTest.java
<https://reviews.apache.org/r/29995/#comment112855>
Same here
- Kasper Sørensen
On jan. 17, 2015, 1:02 a.m., fwelz wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29995/
> -----------------------------------------------------------
>
> (Updated jan. 17, 2015, 1:02 a.m.)
>
>
> Review request for MetaModel.
>
>
> Bugs: METAMODEL-78
> https://issues.apache.org/jira/browse/METAMODEL-78
>
>
> Repository: metamodel
>
>
> Description
> -------
>
> Proposed fix for issue METAMODEL-78
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/metamodel/QueryPostprocessDataContext.java ab2dd71
> pojo/src/test/java/org/apache/metamodel/pojo/PojoDataContextTest.java e345a8c
>
> Diff: https://reviews.apache.org/r/29995/diff/
>
>
> Testing
> -------
>
> Added two tests to scenario in PojoDataContextTest-Unittest
>
>
> Thanks,
>
> fwelz
>
>
Re: Review Request 29995: METAMODEL-78: Fix of not working distinct
select for PojoDataContext (and proabably others, too)
Posted by we...@googlemail.com.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29995/
-----------------------------------------------------------
(Updated Jan. 17, 2015, 8:01 nachm.)
Review request for MetaModel.
Changes
-------
Removed Spaces before linebreak and Spaces in empty rows
Bugs: METAMODEL-78
https://issues.apache.org/jira/browse/METAMODEL-78
Repository: metamodel
Description
-------
Proposed fix for issue METAMODEL-78
Diffs (updated)
-----
core/src/main/java/org/apache/metamodel/QueryPostprocessDataContext.java ab2dd71
pojo/src/test/java/org/apache/metamodel/pojo/PojoDataContextTest.java e345a8c
Diff: https://reviews.apache.org/r/29995/diff/
Testing
-------
Added two tests to scenario in PojoDataContextTest-Unittest
Thanks,
fwelz
Re: Review Request 29995: METAMODEL-78: Fix of not working distinct
select for PojoDataContext (and proabably others, too)
Posted by we...@googlemail.com.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29995/
-----------------------------------------------------------
(Updated Jan. 17, 2015, 2:02 vorm.)
Review request for MetaModel.
Changes
-------
Added issue in summary
Summary (updated)
-----------------
METAMODEL-78: Fix of not working distinct select for PojoDataContext (and proabably others, too)
Bugs: METAMODEL-78
https://issues.apache.org/jira/browse/METAMODEL-78
Repository: metamodel
Description
-------
Proposed fix for issue METAMODEL-78
Diffs
-----
core/src/main/java/org/apache/metamodel/QueryPostprocessDataContext.java ab2dd71
pojo/src/test/java/org/apache/metamodel/pojo/PojoDataContextTest.java e345a8c
Diff: https://reviews.apache.org/r/29995/diff/
Testing
-------
Added two tests to scenario in PojoDataContextTest-Unittest
Thanks,
fwelz