You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "fallintoplace (via GitHub)" <gi...@apache.org> on 2026/06/23 22:36:39 UTC
[PR] fix(table): release empty scan batches [iceberg-go]
fallintoplace opened a new pull request, #1290:
URL: https://github.com/apache/iceberg-go/pull/1290
Summary
- release zero-row record batches before createIterator skips them
- add a checked-allocator regression using a zero-row slice that still owns Arrow buffers
Why
createIterator owns each batch it reads from the sequenced channel. Non-empty batches are handed to the caller, but empty batches were skipped with continue and never released. That could leak Arrow buffers when filters/deletes produce zero-row batches.
Testing
- go test ./table -run '^TestCreateIteratorReleasesEmptyRecordBatches$' -count=1
- go test ./table -count=1
- git diff --check
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] fix(table): release empty scan batches [iceberg-go]
Posted by "laskoviymishka (via GitHub)" <gi...@apache.org>.
laskoviymishka commented on PR #1290:
URL: https://github.com/apache/iceberg-go/pull/1290#issuecomment-4788772454
@fallintoplace good to merge, but you need to fix merge conficts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] fix(table): release empty scan batches [iceberg-go]
Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade merged PR #1290:
URL: https://github.com/apache/iceberg-go/pull/1290
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] fix(table): release empty scan batches [iceberg-go]
Posted by "fallintoplace (via GitHub)" <gi...@apache.org>.
fallintoplace commented on PR #1290:
URL: https://github.com/apache/iceberg-go/pull/1290#issuecomment-4791715152
@laskoviymishka @zeroshade @tanmayrauth Can you please check again when you have time? Thank you for the support.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org