You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@flink.apache.org by kk...@apache.org on 2018/12/05 14:11:41 UTC
[flink] 02/02: [hotfix] Fixing the broken code examples
This is an automated email from the ASF dual-hosted git repository.
kkloudas pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/flink.git
commit 2e1cbf2e3fbfc58051d8a5c3c2b39349bee39b31
Author: Igal Shilman <ig...@data-artisans.com>
AuthorDate: Tue Dec 4 16:45:54 2018 +0100
[hotfix] Fixing the broken code examples
The code examples for Scala and Java are both broken,
and set a bad example in terms of efficiency.
This closes #7232.
---
docs/dev/connectors/streamfile_sink.md | 20 +++++++-------------
1 file changed, 7 insertions(+), 13 deletions(-)
diff --git a/docs/dev/connectors/streamfile_sink.md b/docs/dev/connectors/streamfile_sink.md
index 8f50675..82ab562 100644
--- a/docs/dev/connectors/streamfile_sink.md
+++ b/docs/dev/connectors/streamfile_sink.md
@@ -60,17 +60,14 @@ Basic usage thus looks like this:
<div class="codetabs" markdown="1">
<div data-lang="java" markdown="1">
{% highlight java %}
-import org.apache.flink.api.common.serialization.Encoder;
+import org.apache.flink.api.common.serialization.SimpleStringEncoder;
import org.apache.flink.core.fs.Path;
import org.apache.flink.streaming.api.functions.sink.filesystem.StreamingFileSink;
DataStream<String> input = ...;
final StreamingFileSink<String> sink = StreamingFileSink
- .forRowFormat(new Path(outputPath), (Encoder<String>) (element, stream) -> {
- PrintStream out = new PrintStream(stream);
- out.println(element.f1);
- })
+ .forRowFormat(new Path(outputPath), new SimpleStringEncoder<>("UTF-8"))
.build();
input.addSink(sink);
@@ -79,19 +76,16 @@ input.addSink(sink);
</div>
<div data-lang="scala" markdown="1">
{% highlight scala %}
-import org.apache.flink.api.common.serialization.Encoder
+import org.apache.flink.api.common.serialization.SimpleStringEncoder
import org.apache.flink.core.fs.Path
import org.apache.flink.streaming.api.functions.sink.filesystem.StreamingFileSink
val input: DataStream[String] = ...
-final StreamingFileSink[String] sink = StreamingFileSink
- .forRowFormat(new Path(outputPath), (element, stream) => {
- val out = new PrintStream(stream)
- out.println(element.f1)
- })
- .build()
-
+val sink: StreamingFileSink[String] = StreamingFileSink
+ .forRowFormat(new Path(outputPath), new SimpleStringEncoder[String]("UTF-8"))
+ .build()
+
input.addSink(sink)
{% endhighlight %}