Re: [PR] [improve] [test] Add a test to verify no orphan consumers if release lock caused by checkConnectionLiveness [pulsar]

["merlimat (via GitHub)" <gi...@apache.org>]

merlimat commented on PR #21498:
URL: https://github.com/apache/pulsar/pull/21498#issuecomment-6353950535

   Thanks @poorbarcode for digging into this race, and sorry it sat so long. Master now covers it deterministically: `SharedSubscriptionUnackedMessagesAccountingTest#testCloseCleansUpStickyAdditionCompletedAfterRemoval` (#26652) holds the liveness PONG, closes the pending Key_Shared consumer, and checks that no orphan selector range is left. Since then the dispatcher list is updated before the async selector step, so the leftover state would now be in the selector, not `getConsumers()`. The branch also carries unrelated `RetryMessageUtil`/`PulsarHandler` changes and sleep-based timing. I'm closing this as superseded. If you see a variant that #26652 doesn't cover, please open a fresh PR against master.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org