You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2020/11/13 19:56:04 UTC

[GitHub] [geode] jhutchison opened a new pull request #5748: info executor only returns keypsace info if >0 keys exist

jhutchison opened a new pull request #5748:
URL: https://github.com/apache/geode/pull/5748


   Thank you for submitting a contribution to Apache Geode.
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
   
   - [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
   
   - [ ] Is your initial contribution a single, squashed commit?
   
   - [ ] Does `gradlew build` run cleanly?
   
   - [ ] Have you written or updated unit tests to verify your changes?
   
   - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
   
   ### Note:
   Please ensure that once the PR is submitted, check Concourse for build issues and
   submit an update to your PR as soon as possible. If you need help, please send an
   email to dev@geode.apache.org.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [geode] jhutchison closed pull request #5748: GEODE-8715: Redis INFO command 'Keyspace' section should not be present if no keys in database

Posted by GitBox <gi...@apache.org>.
jhutchison closed pull request #5748:
URL: https://github.com/apache/geode/pull/5748


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [geode] jhutchison commented on pull request #5748: GEODE-8715: Redis INFO command 'Keyspace' section should not be present if no keys in database

Posted by GitBox <gi...@apache.org>.
jhutchison commented on pull request #5748:
URL: https://github.com/apache/geode/pull/5748#issuecomment-728161074


   > Seems good! Just looks like it needs a Jira ticket. [GEODE-8706](https://issues.apache.org/jira/projects/GEODE/issues/GEODE-8706) looks like it's for a different issue.
   
   so it does-  weird- not sure how that happened \_?_/ .   thanks- fixed.   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [geode] jhutchison commented on pull request #5748: GEODE-8715: Redis INFO command 'Keyspace' section should not be present if no keys in database

Posted by GitBox <gi...@apache.org>.
jhutchison commented on pull request #5748:
URL: https://github.com/apache/geode/pull/5748#issuecomment-728174115


   mistakenly assigned unrelated ticket.  Pr closed and reopened in new pr https://github.com/apache/geode/pull/5753 with matching branch name


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [geode] jhutchison commented on pull request #5748: GEODE-8715: Redis INFO command 'Keyspace' section should not be present if no keys in database

Posted by GitBox <gi...@apache.org>.
jhutchison commented on pull request #5748:
URL: https://github.com/apache/geode/pull/5748#issuecomment-728173547


   > > Seems good! Just looks like it needs a Jira ticket. [GEODE-8706](https://issues.apache.org/jira/projects/GEODE/issues/GEODE-8706) looks like it's for a different issue.
   > 
   > so it does- weird- not sure how that happened _?_/ . thanks- fixed.
   
   re-opened pr in https://github.com/apache/geode/pull/5753 with renamed branch and pr.  closing this pr.  


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org