You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by "rimashah25 (via GitHub)" <gi...@apache.org> on 2023/03/23 15:16:57 UTC
[GitHub] [trafficcontrol] rimashah25 opened a new pull request, #7420: DSR Capability Checkbox auto change
rimashah25 opened a new pull request, #7420:
URL: https://github.com/apache/trafficcontrol/pull/7420
<!--
Thank you for contributing! Please be sure to read our contribution guidelines: https://github.com/apache/trafficcontrol/blob/master/CONTRIBUTING.md
If this closes or relates to an existing issue, please reference it using one of the following:
Closes: #ISSUE
Related: #ISSUE
If this PR fixes a security vulnerability, DO NOT submit! Instead, contact
the Apache Traffic Control Security Team at security@trafficcontrol.apache.org and follow the
guidelines at https://apache.org/security regarding vulnerability disclosure.
-->
The DSR current/previous value wasn't auto changing when DS field `Required Capability` were checked and unchecked.
Also, added DSR change box for DS field `Regional Max Origin Connections` which wasn't existing before.
<!-- **^ Add meaningful description above** --><hr/>
## Which Traffic Control components are affected by this PR?
<!-- Please delete all components from this list that are NOT affected by this PR.
Feel free to add the name of a tool or script that is affected but not on the list.
-->
- Traffic Portal
## What is the best way to verify this PR?
<!-- Please include here ALL the steps necessary to test your PR.
If your PR has tests (and most should), provide the steps needed to run the tests.
If not, please provide step-by-step instructions to test the PR manually and explain why your PR does not need tests. -->
For DS `Required Capability`
Reproduce error:
1. For a HTTP/DNS DS, create a DSR
2. Go to the DSR and update capability (check/uncheck box)
3. No current value box will be seen
Solution: Run this branch and repeat steps 1-2. And now you can see current value box.
For DS `Regional Max Origin Connections`
Check and uncheck box and see current value box appear/disappear.
## If this is a bugfix, which Traffic Control versions contained the bug?
<!-- Delete this section if the PR is not a bugfix, or if the bug is only in the master branch.
Examples:
- 5.1.2
- 5.1.3 (RC1)
-->
7.0.1
## PR submission checklist
- [ ] This PR has tests <!-- If not, please delete this text and explain why this PR does not need tests. -->
- [ ] This PR has documentation <!-- If not, please delete this text and explain why this PR does not need documentation. -->
- [ ] This PR has a CHANGELOG.md entry <!-- A fix for a bug from an ATC release, an improvement, or a new feature should have a changelog entry. -->
- [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY** (see [the Apache Software Foundation's security guidelines](https://apache.org/security) for details)
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] shamrickus commented on a diff in pull request #7420: DSR Capability Checkbox auto change
Posted by "shamrickus (via GitHub)" <gi...@apache.org>.
shamrickus commented on code in PR #7420:
URL: https://github.com/apache/trafficcontrol/pull/7420#discussion_r1152494318
##########
traffic_portal/app/src/common/modules/form/deliveryService/FormDeliveryServiceController.js:
##########
@@ -132,6 +132,20 @@ var FormDeliveryServiceController = function(deliveryService, dsCurrent, origin,
};
$scope.arrayCompare = arrayCompare;
+ /**
+ * This function is called when capability is updated on a DSR
+ */
+ function capabilityChange() {
+ cap = []
Review Comment:
`cap` is storing a _reference_ to the array instead of the actual array. So making it `const` works even though we are changing the _value_ because it only restricts changing the _reference_.
In other words, `const` means the value of the `cap` can be changed, but we cannot reassign it to a _different_ array.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] shamrickus commented on a diff in pull request #7420: DSR Capability Checkbox auto change
Posted by "shamrickus (via GitHub)" <gi...@apache.org>.
shamrickus commented on code in PR #7420:
URL: https://github.com/apache/trafficcontrol/pull/7420#discussion_r1151913574
##########
traffic_portal/app/src/common/modules/form/deliveryService/FormDeliveryServiceController.js:
##########
@@ -132,6 +132,20 @@ var FormDeliveryServiceController = function(deliveryService, dsCurrent, origin,
};
$scope.arrayCompare = arrayCompare;
+ /**
+ * This function is called when capability is updated on a DSR
+ */
+ function capabilityChange() {
+ cap = []
Review Comment:
Can be `const`
##########
traffic_portal/app/src/common/modules/form/deliveryService/FormDeliveryServiceController.js:
##########
@@ -132,6 +132,20 @@ var FormDeliveryServiceController = function(deliveryService, dsCurrent, origin,
};
$scope.arrayCompare = arrayCompare;
+ /**
+ * This function is called when capability is updated on a DSR
+ */
+ function capabilityChange() {
Review Comment:
This function is missing semicolons at the end of a couple lines.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] shamrickus commented on a diff in pull request #7420: DSR Capability Checkbox auto change
Posted by "shamrickus (via GitHub)" <gi...@apache.org>.
shamrickus commented on code in PR #7420:
URL: https://github.com/apache/trafficcontrol/pull/7420#discussion_r1152494318
##########
traffic_portal/app/src/common/modules/form/deliveryService/FormDeliveryServiceController.js:
##########
@@ -132,6 +132,20 @@ var FormDeliveryServiceController = function(deliveryService, dsCurrent, origin,
};
$scope.arrayCompare = arrayCompare;
+ /**
+ * This function is called when capability is updated on a DSR
+ */
+ function capabilityChange() {
+ cap = []
Review Comment:
`cap` is storing a _reference_ to the array instead of the actual array. So making it `const` works even though we are changing the _value_ because it only restricts changing the _reference_.
In other words, `const` means the contents of the `cap` can be changed, but we cannot reassign it to a _different_ array.
##########
traffic_portal/app/src/common/modules/form/deliveryService/FormDeliveryServiceController.js:
##########
@@ -132,6 +132,20 @@ var FormDeliveryServiceController = function(deliveryService, dsCurrent, origin,
};
$scope.arrayCompare = arrayCompare;
+ /**
+ * This function is called when capability is updated on a DSR
+ */
+ function capabilityChange() {
+ cap = []
Review Comment:
`cap` is storing a _reference_ to the array instead of the actual array. So making it `const` works even though we are changing the _value_ because it only restricts changing the _reference_.
In other words, `const` means the contents of `cap` can be changed, but we cannot reassign it to a _different_ array.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] shamrickus merged pull request #7420: DSR Capability Checkbox auto change
Posted by "shamrickus (via GitHub)" <gi...@apache.org>.
shamrickus merged PR #7420:
URL: https://github.com/apache/trafficcontrol/pull/7420
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] rimashah25 commented on a diff in pull request #7420: DSR Capability Checkbox auto change
Posted by "rimashah25 (via GitHub)" <gi...@apache.org>.
rimashah25 commented on code in PR #7420:
URL: https://github.com/apache/trafficcontrol/pull/7420#discussion_r1152467892
##########
traffic_portal/app/src/common/modules/form/deliveryService/FormDeliveryServiceController.js:
##########
@@ -132,6 +132,20 @@ var FormDeliveryServiceController = function(deliveryService, dsCurrent, origin,
};
$scope.arrayCompare = arrayCompare;
+ /**
+ * This function is called when capability is updated on a DSR
+ */
+ function capabilityChange() {
+ cap = []
Review Comment:
Why, cap does get updated?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org