You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2022/08/11 11:21:16 UTC
[GitHub] [mynewt-nimble] andrzej-kaczmarek opened a new pull request, #1319: nimble/phy/nrf: Add PA/LNA turn-on time configuration
andrzej-kaczmarek opened a new pull request, #1319:
URL: https://github.com/apache/mynewt-nimble/pull/1319
This allows to define PA/LNA turn-on time which allows it to fully turn
on before actual rx/tx. Currently only supported by nRF53 PHY.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1319: nimble/phy/nrf: Add PA/LNA turn-on time configuration
Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot commented on PR #1319:
URL: https://github.com/apache/mynewt-nimble/pull/1319#issuecomment-1211863182
<!-- style-bot -->
## Style check summary
### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
#### nimble/drivers/nrf5340/src/ble_phy.c
<details>
```diff
@@ -1369,7 +1370,8 @@
/* Toggle peripheral power to reset (just in case) */
NRF_RADIO_NS->POWER = 0;
NRF_RADIO_NS->POWER = 1;
- *(volatile uint32_t *)(NRF_RADIO_NS_BASE + 0x774) = (*(volatile uint32_t* )(NRF_RADIO_NS_BASE + 0x774) & 0xfffffffe) | 0x01000000;
+ *(volatile uint32_t *)(NRF_RADIO_NS_BASE +
+ 0x774) = (*(volatile uint32_t * )(NRF_RADIO_NS_BASE + 0x774) & 0xfffffffe) | 0x01000000;
/* Errata 16 - RADIO: POWER register is not functional
* Workaround: Reset all RADIO registers in firmware.
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] andrzej-kaczmarek merged pull request #1319: nimble/phy/nrf: Add PA/LNA turn-on time configuration
Posted by GitBox <gi...@apache.org>.
andrzej-kaczmarek merged PR #1319:
URL: https://github.com/apache/mynewt-nimble/pull/1319
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1319: nimble/phy/nrf: Add PA/LNA turn-on time configuration
Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot commented on PR #1319:
URL: https://github.com/apache/mynewt-nimble/pull/1319#issuecomment-1211883552
<!-- style-bot -->
## Style check summary
### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
#### nimble/drivers/nrf5340/src/ble_phy.c
<details>
```diff
@@ -1386,7 +1387,8 @@
/* Toggle peripheral power to reset (just in case) */
NRF_RADIO_NS->POWER = 0;
NRF_RADIO_NS->POWER = 1;
- *(volatile uint32_t *)(NRF_RADIO_NS_BASE + 0x774) = (*(volatile uint32_t* )(NRF_RADIO_NS_BASE + 0x774) & 0xfffffffe) | 0x01000000;
+ *(volatile uint32_t *)(NRF_RADIO_NS_BASE +
+ 0x774) = (*(volatile uint32_t * )(NRF_RADIO_NS_BASE + 0x774) & 0xfffffffe) | 0x01000000;
/* Errata 16 - RADIO: POWER register is not functional
* Workaround: Reset all RADIO registers in firmware.
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1319: nimble/phy/nrf: Add PA/LNA turn-on time configuration
Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot commented on PR #1319:
URL: https://github.com/apache/mynewt-nimble/pull/1319#issuecomment-1211868114
<!-- style-bot -->
## Style check summary
### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
#### nimble/drivers/nrf5340/src/ble_phy.c
<details>
```diff
@@ -1385,7 +1386,8 @@
/* Toggle peripheral power to reset (just in case) */
NRF_RADIO_NS->POWER = 0;
NRF_RADIO_NS->POWER = 1;
- *(volatile uint32_t *)(NRF_RADIO_NS_BASE + 0x774) = (*(volatile uint32_t* )(NRF_RADIO_NS_BASE + 0x774) & 0xfffffffe) | 0x01000000;
+ *(volatile uint32_t *)(NRF_RADIO_NS_BASE +
+ 0x774) = (*(volatile uint32_t * )(NRF_RADIO_NS_BASE + 0x774) & 0xfffffffe) | 0x01000000;
/* Errata 16 - RADIO: POWER register is not functional
* Workaround: Reset all RADIO registers in firmware.
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1319: nimble/phy/nrf: Add PA/LNA turn-on time configuration
Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot commented on PR #1319:
URL: https://github.com/apache/mynewt-nimble/pull/1319#issuecomment-1211892334
<!-- style-bot -->
## Style check summary
### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
#### nimble/drivers/nrf5340/src/ble_phy.c
<details>
```diff
@@ -1386,7 +1387,8 @@
/* Toggle peripheral power to reset (just in case) */
NRF_RADIO_NS->POWER = 0;
NRF_RADIO_NS->POWER = 1;
- *(volatile uint32_t *)(NRF_RADIO_NS_BASE + 0x774) = (*(volatile uint32_t* )(NRF_RADIO_NS_BASE + 0x774) & 0xfffffffe) | 0x01000000;
+ *(volatile uint32_t *)(NRF_RADIO_NS_BASE +
+ 0x774) = (*(volatile uint32_t * )(NRF_RADIO_NS_BASE + 0x774) & 0xfffffffe) | 0x01000000;
/* Errata 16 - RADIO: POWER register is not functional
* Workaround: Reset all RADIO registers in firmware.
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org