[GitHub] [incubator-doris] morningman commented on a change in pull request #4991: [Enhance] Add "statistics" meta table and fix some mysql compatibility problem

[GitBox <gi...@apache.org>]

morningman commented on a change in pull request #4991:
URL: https://github.com/apache/incubator-doris/pull/4991#discussion_r533142814



##########
File path: fe/fe-core/src/main/java/org/apache/doris/catalog/PrimitiveType.java
##########
@@ -710,7 +718,8 @@ public MysqlColType toMysqlType() {
             }
             case DECIMAL:
             case DECIMALV2:
-                return MysqlColType.MYSQL_TYPE_DECIMAL;
+                // update by songchuanyuan

Review comment:
       Remove author name, it is not necessary

##########
File path: fe/fe-core/src/main/java/org/apache/doris/catalog/PrimitiveType.java
##########
@@ -546,6 +546,14 @@ public void setTimeType() {
         isTimeType = true;
     }
 
+    /**
+     * @return
+     * @add by songchuanyuan
+     */
+    public boolean getTimeType() {

Review comment:
       ```suggestion
       public boolean isTimeType() {
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org