[GitHub] spark pull request: [SPARK-12468] [Pyspark] extractParamMap return...

[yanboliang <gi...@git.apache.org>]

Github user yanboliang commented on the pull request:

    https://github.com/apache/spark/pull/10419#issuecomment-166794601
  
    @ZacharySBrown Thanks for catching this bug. But I think setting ```a._paramMap``` with ```self.extractParamMap()``` is not appropriate. Because you set the child/Model's ```_paramMap``` with its parent/Estimator's ```_paramMap```, and this has already done at Scala side. I think what we should do is to call [```_transfer_params_from_java```](https://github.com/apache/spark/blob/master/python/pyspark/ml/wrapper.py#L85) which will transforms the embedded params from the companion Java model.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org