[GitHub] [maven-wrapper] slawekjaranowski commented on a diff in pull request #51: [MWRAPPER-68] fix issue with MVNW_REPOURL path resolving

[GitBox <gi...@apache.org>]

slawekjaranowski commented on code in PR #51:
URL: https://github.com/apache/maven-wrapper/pull/51#discussion_r897961002


##########
maven-wrapper/pom.xml:
##########
@@ -40,6 +40,12 @@ under the License.
       <version>4.13.2</version>
       <scope>test</scope>
     </dependency>
+    <dependency>
+      <groupId>com.github.stefanbirkner</groupId>
+      <artifactId>system-rules</artifactId>
+      <version>1.19.0</version>
+      <scope>test</scope>
+    </dependency>

Review Comment:
   I see that is licensed on CPL 1.0
   It is CATEGORY B - https://www.apache.org/legal/resolved.html#category-b
   I don't want to consider a specified conditions for it.
   
   for test purpose we can add method eg. getEnv(key) to Installer and next use spy or override method in test



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org