You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/11/01 15:55:10 UTC

[GitHub] [arrow-rs] alamb commented on a diff in pull request #2971: Specialize filter kernel for binary arrays (#2969)

alamb commented on code in PR #2971:
URL: https://github.com/apache/arrow-rs/pull/2971#discussion_r1010599750


##########
arrow-select/src/filter.rs:
##########
@@ -626,17 +626,17 @@ where
 ///
 /// Note: NULLs with a non-zero slot length in `array` will have the corresponding
 /// data copied across. This allows handling the null mask separately from the data
-fn filter_string<OffsetSize>(
-    array: &GenericStringArray<OffsetSize>,
+fn filter_bytes<T>(

Review Comment:
   The comment a few lines above is now out of date:
   
   > /// `filter` implementation for string arrays
   
   Should be:
   
   > /// `filter` implementation for byte arrays



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org