You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2017/06/02 00:58:35 UTC
[kudu-CR] ts recovery-itest: bump timeouts
Hello Mike Percy,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/7050
to review the following change.
Change subject: ts_recovery-itest: bump timeouts
......................................................................
ts_recovery-itest: bump timeouts
In TSAN mode this test seems to be relatively flaky due to not crashing
within the expected amount of time. If writes are very slow (eg one per
second), then a crash on 5% of log commits may take a couple of minutes
before it happens in the worst case.
Change-Id: Icdf05c6a2a1616c9a653539af1c40962acad212f
---
M src/kudu/integration-tests/ts_recovery-itest.cc
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/50/7050/1
--
To view, visit http://gerrit.cloudera.org:8080/7050
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Icdf05c6a2a1616c9a653539af1c40962acad212f
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
[kudu-CR] ts recovery-itest: bump timeouts
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change.
Change subject: ts_recovery-itest: bump timeouts
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7050
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icdf05c6a2a1616c9a653539af1c40962acad212f
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-HasComments: No
[kudu-CR] ts recovery-itest: bump timeouts
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged.
Change subject: ts_recovery-itest: bump timeouts
......................................................................
ts_recovery-itest: bump timeouts
In TSAN mode this test seems to be relatively flaky due to not crashing
within the expected amount of time. If writes are very slow (eg one per
second), then a crash on 5% of log commits may take a couple of minutes
before it happens in the worst case.
Change-Id: Icdf05c6a2a1616c9a653539af1c40962acad212f
Reviewed-on: http://gerrit.cloudera.org:8080/7050
Reviewed-by: Mike Percy <mp...@apache.org>
Tested-by: Kudu Jenkins
---
M src/kudu/integration-tests/ts_recovery-itest.cc
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Mike Percy: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/7050
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icdf05c6a2a1616c9a653539af1c40962acad212f
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>