You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/02/19 04:18:33 UTC
[GitHub] [apisix-dashboard] Firstsawyou opened a new issue #1482: from the QQ group: how to delete the historical version of the APISIX node.
Firstsawyou opened a new issue #1482:
URL: https://github.com/apache/apisix-dashboard/issues/1482
## System information
- OS: [e.g. macOS, Windows]
- Browser (if applies) [e.g. Chrome, Safari, Edge]
- Version: [e.g. 2.0-rc3]: dashboard 2.4
How to delete the extra historical version in the APISIX node? It prompts mismatch when deleting.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] LiteSun commented on issue #1482: how to delete the historical version of the APISIX node.
Posted by GitBox <gi...@apache.org>.
LiteSun commented on issue #1482:
URL: https://github.com/apache/apisix-dashboard/issues/1482#issuecomment-800831220
cc @guoqqqi to take a look.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on issue #1482: how to delete the historical version of the APISIX node.
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #1482:
URL: https://github.com/apache/apisix-dashboard/issues/1482#issuecomment-802523508
Hi, after discuss with @nic-chen @starsz @LiteSun, we have a new way to support this feature.
How about only adding one extra message that tells users: `APISIX Node List will get updated in 2 hours by default.`, then we don't have necessary to remove nodes by hand & calling APIs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on issue #1482: how to delete the historical version of the APISIX node.
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #1482:
URL: https://github.com/apache/apisix-dashboard/issues/1482#issuecomment-803715434
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] bisakhmondal commented on issue #1482: how to delete the historical version of the APISIX node.
Posted by GitBox <gi...@apache.org>.
bisakhmondal commented on issue #1482:
URL: https://github.com/apache/apisix-dashboard/issues/1482#issuecomment-799643197
Oh! I see. Then, I am going to look into it.
>We could also support manual deletion of node data, what do you think?
So this is the idea, right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] starsz commented on issue #1482: how to delete the historical version of the APISIX node.
Posted by GitBox <gi...@apache.org>.
starsz commented on issue #1482:
URL: https://github.com/apache/apisix-dashboard/issues/1482#issuecomment-782465024
> Plugin `server-info` supports the expiration time of the specified information([refer](https://github.com/apache/apisix/blob/master/doc/plugins/server-info.md#how-to-customize-the-server-info-report-configurations)).
>
> We could also support manual deletion of node data, what do you think? @starsz @juzhiyuan
Agree +1.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on issue #1482: how to delete the historical version of the APISIX node.
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #1482:
URL: https://github.com/apache/apisix-dashboard/issues/1482#issuecomment-802525066
If we support deleting nodes, it will take some other issues:
1. Where should we put the Delete button on this page?
2. Nodes in ETCD have the TTL option, it will expire in 2 hours by default, we don't have the necessary to delete it by hand.
3. If users delete nodes by mistake, they have to wait for APISIX to report its status, though it doesn't take a long time, users like me will get scared if we are not familiar with this logic (Only delete metrics from ETCD).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on issue #1482: how to delete the historical version of the APISIX node.
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #1482:
URL: https://github.com/apache/apisix-dashboard/issues/1482#issuecomment-802814756
Good design 👏 But I'm still concerned if we have necessary to add this API? let's wait for others :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] bisakhmondal commented on issue #1482: how to delete the historical version of the APISIX node.
Posted by GitBox <gi...@apache.org>.
bisakhmondal commented on issue #1482:
URL: https://github.com/apache/apisix-dashboard/issues/1482#issuecomment-802620825
> Hi, after discuss with @nic-chen @starsz @LiteSun, we have a new way to support this feature.
>
> How about only adding one extra message that tells users: `APISIX Node List will get updated in 2 hours by default.`, then we don't have necessary to remove nodes by hand & calling APIs.
Yeah, that's the default we have right now except for the displaying message part. We can definitely go for it. But looking at the current progress that has been made on this issue, I think it would be a better trade off to integrate the functionality since it'll help the pro peeps to have more customised & fine-grained control through the dashboard instead of waiting for 2 long hours.
Now coming to the implementation of the UI
>Where should we put the Delete button on this page?
>If users delete nodes by mistake, they have to wait for APISIX to report its status, though it doesn't take a long time, users like me will get scared if we are not familiar with this logic (Only delete metrics from ETCD).
I have prepared a mock-up for the same, which I think should address these concerns :)
The default screen:
On clicking the unlock, the user will be prompted with the necessary warnings.
upon confirming to accept button, he/she will have fine-grained access.
I have made the assets available on [google slides](https://docs.google.com/presentation/d/1Gmn-iLR66VO-YOrfmzBWlMsdOBfujigmJGY-fbv45Dc/edit?usp=sharing). Feel free to tinker with it & share your thoughts.
I think this omits the risk of unexpectedly deleting apisix node data by mistake. Let me know what you think. I'd be happy to address those. Thank you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on issue #1482: how to delete the historical version of the APISIX node.
Posted by GitBox <gi...@apache.org>.
nic-chen commented on issue #1482:
URL: https://github.com/apache/apisix-dashboard/issues/1482#issuecomment-802528995
> Hi, after discuss with @nic-chen @starsz @LiteSun, we have a new way to support this feature.
>
> How about only adding one extra message that tells users: `APISIX Node List will get updated in 2 hours by default.`, then we don't have necessary to remove nodes by hand & calling APIs.
OK
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen edited a comment on issue #1482: how to delete the historical version of the APISIX node.
Posted by GitBox <gi...@apache.org>.
nic-chen edited a comment on issue #1482:
URL: https://github.com/apache/apisix-dashboard/issues/1482#issuecomment-796620673
@bisakhmondal hi, could you help to fix this issue if you have time ? thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on issue #1482: how to delete the historical version of the APISIX node.
Posted by GitBox <gi...@apache.org>.
nic-chen commented on issue #1482:
URL: https://github.com/apache/apisix-dashboard/issues/1482#issuecomment-799447872
@bisakhmondal
Please deal with this issue first, it is a task in milestone 2.5, thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on issue #1482: how to delete the historical version of the APISIX node.
Posted by GitBox <gi...@apache.org>.
nic-chen commented on issue #1482:
URL: https://github.com/apache/apisix-dashboard/issues/1482#issuecomment-802751148
@bisakhmondal
Great!
Thanks for sharing your thoughts.
I think we can discuss further.
But in version 2.5 we could prompt the user first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan closed issue #1482: how to delete the historical version of the APISIX node.
Posted by GitBox <gi...@apache.org>.
juzhiyuan closed issue #1482:
URL: https://github.com/apache/apisix-dashboard/issues/1482
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] bisakhmondal commented on issue #1482: how to delete the historical version of the APISIX node.
Posted by GitBox <gi...@apache.org>.
bisakhmondal commented on issue #1482:
URL: https://github.com/apache/apisix-dashboard/issues/1482#issuecomment-796633258
Yeah definitely.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on issue #1482: how to delete the historical version of the APISIX node.
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #1482:
URL: https://github.com/apache/apisix-dashboard/issues/1482#issuecomment-894945497
Due to these nodes will get dropped after some time, so close this issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on issue #1482: how to delete the historical version of the APISIX node.
Posted by GitBox <gi...@apache.org>.
nic-chen commented on issue #1482:
URL: https://github.com/apache/apisix-dashboard/issues/1482#issuecomment-796620673
@bisakhmondal hi, could you help to fix this issue if you have time ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on issue #1482: how to delete the historical version of the APISIX node.
Posted by GitBox <gi...@apache.org>.
nic-chen commented on issue #1482:
URL: https://github.com/apache/apisix-dashboard/issues/1482#issuecomment-781866128
Plugin `server-info` supports the expiration time of the specified information([refer](https://github.com/apache/apisix/blob/master/doc/plugins/server-info.md#how-to-customize-the-server-info-report-configurations)).
We could also support manual deletion of node data, what do you think? @starsz @juzhiyuan
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on issue #1482: how to delete the historical version of the APISIX node.
Posted by GitBox <gi...@apache.org>.
nic-chen commented on issue #1482:
URL: https://github.com/apache/apisix-dashboard/issues/1482#issuecomment-797294000
@bisakhmondal
Thanks !
I think you could try to submit a proposal for this change : )
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on issue #1482: how to delete the historical version of the APISIX node.
Posted by GitBox <gi...@apache.org>.
nic-chen commented on issue #1482:
URL: https://github.com/apache/apisix-dashboard/issues/1482#issuecomment-799926101
> Oh! I see. Then, I am going to look into it.
>
> > We could also support manual deletion of node data, what do you think?
>
> So this is the idea, right?
sure. that's it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org