You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Yingchun Lai (Code Review)" <ge...@cloudera.org> on 2019/04/29 15:13:19 UTC
[kudu-CR] tserver: remove some duplicated code
Yingchun Lai has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13174
Change subject: tserver: remove some duplicated code
......................................................................
tserver: remove some duplicated code
Change-Id: I950673eb0e54b08f52fdb2eb8ce4e16e49c8bea5
---
M src/kudu/tserver/tablet_service.cc
1 file changed, 8 insertions(+), 11 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/74/13174/1
--
To view, visit http://gerrit.cloudera.org:8080/13174
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I950673eb0e54b08f52fdb2eb8ce4e16e49c8bea5
Gerrit-Change-Number: 13174
Gerrit-PatchSet: 1
Gerrit-Owner: Yingchun Lai <40...@qq.com>
[kudu-CR] tserver: remove some duplicated code
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/13174 )
Change subject: tserver: remove some duplicated code
......................................................................
Removed reviewer Kudu Jenkins with the following votes:
* Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/13174
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteReviewer
Gerrit-Change-Id: I950673eb0e54b08f52fdb2eb8ce4e16e49c8bea5
Gerrit-Change-Number: 13174
Gerrit-PatchSet: 1
Gerrit-Owner: Yingchun Lai <40...@qq.com>
[kudu-CR] tserver: remove some duplicated code
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13174 )
Change subject: tserver: remove some duplicated code
......................................................................
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/13174/2/src/kudu/tserver/tablet_service.cc
File src/kudu/tserver/tablet_service.cc:
http://gerrit.cloudera.org:8080/#/c/13174/2/src/kudu/tserver/tablet_service.cc@1665
PS2, Line 1665: if (!LookupRunningTabletReplicaOrRespond(server_->tablet_manager(), scan_pb.tablet_id(), resp,
: context, &replica)) {
: return;
: }
Looks like this is duplication too, if we're servicing a new scan and enforcing access control.
http://gerrit.cloudera.org:8080/#/c/13174/2/src/kudu/tserver/tablet_service.cc@1971
PS2, Line 1971: if (!LookupRunningTabletReplicaOrRespond(server_->tablet_manager(), new_req.tablet_id(), resp,
Here too.
--
To view, visit http://gerrit.cloudera.org:8080/13174
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I950673eb0e54b08f52fdb2eb8ce4e16e49c8bea5
Gerrit-Change-Number: 13174
Gerrit-PatchSet: 2
Gerrit-Owner: Yingchun Lai <40...@qq.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Comment-Date: Mon, 29 Apr 2019 23:08:58 +0000
Gerrit-HasComments: Yes
[kudu-CR] tserver: remove some duplicated code
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13174 )
Change subject: tserver: remove some duplicated code
......................................................................
tserver: remove some duplicated code
Change-Id: I950673eb0e54b08f52fdb2eb8ce4e16e49c8bea5
Reviewed-on: http://gerrit.cloudera.org:8080/13174
Tested-by: Alexey Serbin <as...@cloudera.com>
Reviewed-by: Alexey Serbin <as...@cloudera.com>
Reviewed-by: Andrew Wong <aw...@cloudera.com>
---
M src/kudu/tserver/tablet_service.cc
1 file changed, 8 insertions(+), 11 deletions(-)
Approvals:
Alexey Serbin: Looks good to me, approved; Verified
Andrew Wong: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/13174
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I950673eb0e54b08f52fdb2eb8ce4e16e49c8bea5
Gerrit-Change-Number: 13174
Gerrit-PatchSet: 2
Gerrit-Owner: Yingchun Lai <40...@qq.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
[kudu-CR] tserver: remove some duplicated code
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13174 )
Change subject: tserver: remove some duplicated code
......................................................................
Patch Set 1: Verified+1
unrelated flakes in tests:
* org.apache.kudu.backup.TestKuduBackup
* org.apache.kudu.client.TestTimeouts
* org.apache.kudu.client.TestKuduPartitioner
* org.apache.kudu.client.TestHybridTime
--
To view, visit http://gerrit.cloudera.org:8080/13174
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I950673eb0e54b08f52fdb2eb8ce4e16e49c8bea5
Gerrit-Change-Number: 13174
Gerrit-PatchSet: 1
Gerrit-Owner: Yingchun Lai <40...@qq.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Comment-Date: Mon, 29 Apr 2019 17:07:11 +0000
Gerrit-HasComments: No
[kudu-CR] tserver: remove some duplicated code
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13174 )
Change subject: tserver: remove some duplicated code
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/13174
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I950673eb0e54b08f52fdb2eb8ce4e16e49c8bea5
Gerrit-Change-Number: 13174
Gerrit-PatchSet: 1
Gerrit-Owner: Yingchun Lai <40...@qq.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Comment-Date: Mon, 29 Apr 2019 17:29:05 +0000
Gerrit-HasComments: No
[kudu-CR] tserver: remove some duplicated code
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13174 )
Change subject: tserver: remove some duplicated code
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/13174
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I950673eb0e54b08f52fdb2eb8ce4e16e49c8bea5
Gerrit-Change-Number: 13174
Gerrit-PatchSet: 1
Gerrit-Owner: Yingchun Lai <40...@qq.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Comment-Date: Mon, 29 Apr 2019 17:07:27 +0000
Gerrit-HasComments: No