You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@jackrabbit.apache.org by GitBox <gi...@apache.org> on 2022/10/10 15:48:46 UTC

[GitHub] [jackrabbit-oak] mreutegg commented on a diff in pull request #724: OAK-9959 allow to disable registering MBeans for every Session

mreutegg commented on code in PR #724:
URL: https://github.com/apache/jackrabbit-oak/pull/724#discussion_r991434254


##########
oak-jcr/src/main/java/org/apache/jackrabbit/oak/jcr/Jcr.java:
##########
@@ -96,7 +98,7 @@ public class Jcr {
 
     public Jcr(Oak oak, boolean initialize) {
         this.oak = oak;
-
+        createSessionMBeans = true; // by default every (long-living) session will register an MBean

Review Comment:
   Looks good to me, but I would rather move this initialization up to where the field is defined. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org