You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jdo-dev@db.apache.org by "Ilan Kirsh (JIRA)" <ji...@apache.org> on 2006/04/20 06:31:34 UTC
[jira] Created: (JDO-370) Valid query seems invalid in
SetterReplacePreviousValues
Valid query seems invalid in SetterReplacePreviousValues
--------------------------------------------------------
Key: JDO-370
URL: http://issues.apache.org/jira/browse/JDO-370
Project: JDO
Type: Bug
Components: tck20
Reporter: Ilan Kirsh
Probably I am missing something, but as far as I can see the second valid query in org.apache.jdo.tck.query.api.SetterReplacePreviousValues, has a String parameter and receives a long argument, so it should throw an exception, isn't it?
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Assigned: (JDO-370) Valid query seems invalid in
SetterReplacePreviousValues
Posted by "Michael Bouschen (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/JDO-370?page=all ]
Michael Bouschen reassigned JDO-370:
------------------------------------
Assign To: Michael Bouschen
> Valid query seems invalid in SetterReplacePreviousValues
> --------------------------------------------------------
>
> Key: JDO-370
> URL: http://issues.apache.org/jira/browse/JDO-370
> Project: JDO
> Type: Bug
> Components: tck20
> Reporter: Ilan Kirsh
> Assignee: Michael Bouschen
> Attachments: JDO-370.patch
>
> Probably I am missing something, but as far as I can see the second valid query in org.apache.jdo.tck.query.api.SetterReplacePreviousValues, has a String parameter and receives a long argument, so it should throw an exception, isn't it?
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (JDO-370) Valid query seems invalid in
SetterReplacePreviousValues
Posted by "Ilan Kirsh (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/JDO-370?page=comments#action_12375362 ]
Ilan Kirsh commented on JDO-370:
--------------------------------
Thanks. The patch works well - I just passed this test case now.
> Valid query seems invalid in SetterReplacePreviousValues
> --------------------------------------------------------
>
> Key: JDO-370
> URL: http://issues.apache.org/jira/browse/JDO-370
> Project: JDO
> Type: Bug
> Components: tck20
> Reporter: Ilan Kirsh
> Assignee: Michael Bouschen
> Attachments: JDO-370.patch
>
> Probably I am missing something, but as far as I can see the second valid query in org.apache.jdo.tck.query.api.SetterReplacePreviousValues, has a String parameter and receives a long argument, so it should throw an exception, isn't it?
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (JDO-370) Valid query seems invalid in
SetterReplacePreviousValues
Posted by "Michael Bouschen (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/JDO-370?page=all ]
Michael Bouschen updated JDO-370:
---------------------------------
Attachment: JDO-370.patch
Good catch! I agree, the second query is invalid. It is supposed to be testing the replacement of the query filter, so it does not need to declare (and set) any parameters.
Attached you find a patch (JDO-370.patch) for review. With this patch the second and third query do not declare any parameters and do not pass any actual parameter values to execute. I propose I fix this in the trunk and in the 2.0 branch.
> Valid query seems invalid in SetterReplacePreviousValues
> --------------------------------------------------------
>
> Key: JDO-370
> URL: http://issues.apache.org/jira/browse/JDO-370
> Project: JDO
> Type: Bug
> Components: tck20
> Reporter: Ilan Kirsh
> Attachments: JDO-370.patch
>
> Probably I am missing something, but as far as I can see the second valid query in org.apache.jdo.tck.query.api.SetterReplacePreviousValues, has a String parameter and receives a long argument, so it should throw an exception, isn't it?
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (JDO-370) Valid query seems invalid in
SetterReplacePreviousValues
Posted by "Michael Bouschen (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/JDO-370?page=all ]
Michael Bouschen updated JDO-370:
---------------------------------
Fix Version: JDO 2 final
Version: JDO 2 rc1
> Valid query seems invalid in SetterReplacePreviousValues
> --------------------------------------------------------
>
> Key: JDO-370
> URL: http://issues.apache.org/jira/browse/JDO-370
> Project: JDO
> Type: Bug
> Components: tck20
> Versions: JDO 2 rc1
> Reporter: Ilan Kirsh
> Assignee: Michael Bouschen
> Fix For: JDO 2 final
> Attachments: JDO-370.patch
>
> Probably I am missing something, but as far as I can see the second valid query in org.apache.jdo.tck.query.api.SetterReplacePreviousValues, has a String parameter and receives a long argument, so it should throw an exception, isn't it?
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Resolved: (JDO-370) Valid query seems invalid in
SetterReplacePreviousValues
Posted by "Michael Bouschen (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/JDO-370?page=all ]
Michael Bouschen resolved JDO-370:
----------------------------------
Resolution: Fixed
I checked in the patch into the 2.0 branch (revision 395620) and into the trunk (revision 395621).
> Valid query seems invalid in SetterReplacePreviousValues
> --------------------------------------------------------
>
> Key: JDO-370
> URL: http://issues.apache.org/jira/browse/JDO-370
> Project: JDO
> Type: Bug
> Components: tck20
> Versions: JDO 2 rc1
> Reporter: Ilan Kirsh
> Assignee: Michael Bouschen
> Fix For: JDO 2 final
> Attachments: JDO-370.patch
>
> Probably I am missing something, but as far as I can see the second valid query in org.apache.jdo.tck.query.api.SetterReplacePreviousValues, has a String parameter and receives a long argument, so it should throw an exception, isn't it?
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (JDO-370) Valid query seems invalid in
SetterReplacePreviousValues
Posted by "Craig Russell (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/JDO-370?page=comments#action_12375360 ]
Craig Russell commented on JDO-370:
-----------------------------------
The patch looks good.
I'd have to look more carefully, but generally by the specification, it's not illegal to declare parameters that are not used in the query filter. So the mismatch would not be discovered since there is no need to look at the parameter values. But this case isn't covered by the spec, so it is good to fix the test case.
> Valid query seems invalid in SetterReplacePreviousValues
> --------------------------------------------------------
>
> Key: JDO-370
> URL: http://issues.apache.org/jira/browse/JDO-370
> Project: JDO
> Type: Bug
> Components: tck20
> Reporter: Ilan Kirsh
> Assignee: Michael Bouschen
> Attachments: JDO-370.patch
>
> Probably I am missing something, but as far as I can see the second valid query in org.apache.jdo.tck.query.api.SetterReplacePreviousValues, has a String parameter and receives a long argument, so it should throw an exception, isn't it?
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira