You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2019/11/27 14:54:09 UTC

[GitHub] [ignite] Mmuzaf commented on a change in pull request #6960: IGNITE-12193 Add cacheGroup metrics.

Mmuzaf commented on a change in pull request #6960: IGNITE-12193 Add cacheGroup metrics.
URL: https://github.com/apache/ignite/pull/6960#discussion_r351300158
 
 

 ##########
 File path: modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/preloader/GridDhtPartitionDemander.java
 ##########
 @@ -331,6 +334,8 @@ Runnable addAssignments(
 
                 fut.onDone(false);
 
+                grp.metrics().finishRebalance();
 
 Review comment:
   I think it is better to set the `rebalance end time` metric in overridden `onDone` the rebalance future method.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services