You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "yuluo-yx (via GitHub)" <gi...@apache.org> on 2026/08/29 16:26:10 UTC

[PR] [ISSUE #2770] fix(acl): reject invalid wildcard target addresses [rocketmq-dashboard]

yuluo-yx opened a new pull request, #2793:
URL: https://github.com/apache/rocketmq-dashboard/pull/2793

   ## Summary
   
   - parse target addresses before accepting ACL wildcard entries
   - reject non-address strings without changing valid IPv4/IPv6 wildcard behavior
   - cover malformed targets for IPv4 and IPv6 wildcards
   
   ## Verification
   
   - mise x java@temurin-21 -- mvn -Dtest=IpRangeMatcherTest test: 15 tests passed
   - Checkstyle passed
   - scope check: 6 changed lines
   
   Fixes #2770
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [ISSUE #2770] fix(acl): reject invalid wildcard target addresses [rocketmq-dashboard]

Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins closed pull request #2793: [ISSUE #2770] fix(acl): reject invalid wildcard target addresses
URL: https://github.com/apache/rocketmq-dashboard/pull/2793


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [ISSUE #2770] fix(acl): reject invalid wildcard target addresses [rocketmq-dashboard]

Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins commented on PR #2793:
URL: https://github.com/apache/rocketmq-dashboard/pull/2793#issuecomment-5477555302

   Closing: these patches defend against inputs that cannot occur (e.g., JSON payloads cannot carry NaN/Infinity, and backend-produced fields do not contain stray whitespace). The linked issues were self-filed minutes before the PRs were opened. If you have observed a real defect, please provide reproduction steps or logs, and submit one cohesive PR per functional domain. See the maintainer note on #2724.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org