[GitHub] [daffodil] stevedlawrence opened a new pull request #680: Append needed WiX options to default lightOptions rather than overriding

[GitBox <gi...@apache.org>]

stevedlawrence opened a new pull request #680:
URL: https://github.com/apache/daffodil/pull/680


   The lightOptions key in the sbt-native-packager plugin defaults to this:
   
       lightOptions := Seq(
         "-ext", "WixUIExtension",
         "-ext", "WixUtilExtension",
         "-cultures:en-us",
       )
   
   We override the lightOptions setting with these same values plus some
   additional ones for things like localization and disabling validation.
   But we accidentally didn't include the WixUtilExtesnsion option. At some
   point an update required this extension, and without it MSI builds
   started to fail.
   
   We could add the missing WixUtilExtension value to our overridden
   lightOptions setting, but to ensure we pick up any defaults that the
   sbt-native-packager plugin might add and require in the future, this
   instead just appends our custom options to the existing setting by using
   ++=. This gives us back the WixUtilExtenion that we need for builds to
   succeed.
   
   Additionally, minor fixs are made to the bat script:
   - Enable setlocal so variables used in the bat file do not pollute
     variable scope outside the bat file
   - Quote variables inside if-statements. Otherwise, variables with
     parenthesis in them (which is common in Windows (x86) path) cause
     bat-file errors.
   
   DAFFODIL-2584


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [daffodil] stevedlawrence merged pull request #680: Append needed WiX options to default lightOptions rather than overriding

[GitBox <gi...@apache.org>]

stevedlawrence merged pull request #680:
URL: https://github.com/apache/daffodil/pull/680


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org