You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/12/30 02:28:07 UTC
[GitHub] [flink] xintongsong opened a new pull request #10716: [FLINK-15367]
Handle backwards compatibility of "taskmanager.heap.size" differently for
standalone / active setups
xintongsong opened a new pull request #10716: [FLINK-15367] Handle backwards compatibility of "taskmanager.heap.size" differently for standalone / active setups
URL: https://github.com/apache/flink/pull/10716
## What is the purpose of the change
This PR maps the legacy config option `taskmanager.heap.size` to `taskmanager.memory.flink.size` for standalone setups, and `taskmanager.memory.process.size` for containerized setups.
This PR is based on #10677.
## Brief change log
-ae9d67660883a7cb21115e99b9292e6d9f97357a..7092904e562008a9e676c020e573ff3c24af3e98: commits of previous PR
- c40753c2676ef2e9b54e96ec96b8c0a8d66b1c6d..962355cbf2efa230e697305e7408849fb24ef590, 68e5c62f5520559749307a6e2a2667434d5754cf: hotfixes, clean-ups and refactors.
- 417821908939778fe4236e4480875efae9acdaf0: Map legacy `taskmanager.heap.size` to different new config options for standalone / containerized setups.
## Verifying this change
- Add backwards compatibility tests in `TaskExecutorResourceUtilsTest`
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10716:
[FLINK-15367][runtime] Handle backwards compatibility of
"taskmanager.heap.size" differently for standalone / active setups
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10716: [FLINK-15367][runtime] Handle backwards compatibility of "taskmanager.heap.size" differently for standalone / active setups
URL: https://github.com/apache/flink/pull/10716#issuecomment-569571340
<!--
Meta data
Hash:68e5c62f5520559749307a6e2a2667434d5754cf Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3971 TriggerType:PUSH TriggerID:68e5c62f5520559749307a6e2a2667434d5754cf
Hash:68e5c62f5520559749307a6e2a2667434d5754cf Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142609810 TriggerType:PUSH TriggerID:68e5c62f5520559749307a6e2a2667434d5754cf
Hash:4900d684fedd60206559131a3d9eb2dde2c86125 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142978212 TriggerType:PUSH TriggerID:4900d684fedd60206559131a3d9eb2dde2c86125
Hash:4900d684fedd60206559131a3d9eb2dde2c86125 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4070 TriggerType:PUSH TriggerID:4900d684fedd60206559131a3d9eb2dde2c86125
Hash:eb8c0fc6d97f6e928e2a1c58bfb2c978096665e7 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143077006 TriggerType:PUSH TriggerID:eb8c0fc6d97f6e928e2a1c58bfb2c978096665e7
Hash:eb8c0fc6d97f6e928e2a1c58bfb2c978096665e7 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4091 TriggerType:PUSH TriggerID:eb8c0fc6d97f6e928e2a1c58bfb2c978096665e7
Hash:eb8c0fc6d97f6e928e2a1c58bfb2c978096665e7 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/143077006 TriggerType:MANUAL TriggerID:570976914
Hash:eb8c0fc6d97f6e928e2a1c58bfb2c978096665e7 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4091 TriggerType:MANUAL TriggerID:570976914
-->
## CI report:
* 68e5c62f5520559749307a6e2a2667434d5754cf Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142609810) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3971)
* 4900d684fedd60206559131a3d9eb2dde2c86125 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142978212) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4070)
* eb8c0fc6d97f6e928e2a1c58bfb2c978096665e7 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/143077006) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4091)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] xintongsong commented on issue #10716:
[FLINK-15367][runtime] Handle backwards compatibility of
"taskmanager.heap.size" differently for standalone / active setups
Posted by GitBox <gi...@apache.org>.
xintongsong commented on issue #10716: [FLINK-15367][runtime] Handle backwards compatibility of "taskmanager.heap.size" differently for standalone / active setups
URL: https://github.com/apache/flink/pull/10716#issuecomment-570983817
@flinkbot run travis
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10716:
[FLINK-15367][runtime] Handle backwards compatibility of
"taskmanager.heap.size" differently for standalone / active setups
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10716: [FLINK-15367][runtime] Handle backwards compatibility of "taskmanager.heap.size" differently for standalone / active setups
URL: https://github.com/apache/flink/pull/10716#issuecomment-569571340
<!--
Meta data
Hash:68e5c62f5520559749307a6e2a2667434d5754cf Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3971 TriggerType:PUSH TriggerID:68e5c62f5520559749307a6e2a2667434d5754cf
Hash:68e5c62f5520559749307a6e2a2667434d5754cf Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142609810 TriggerType:PUSH TriggerID:68e5c62f5520559749307a6e2a2667434d5754cf
Hash:4900d684fedd60206559131a3d9eb2dde2c86125 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142978212 TriggerType:PUSH TriggerID:4900d684fedd60206559131a3d9eb2dde2c86125
Hash:4900d684fedd60206559131a3d9eb2dde2c86125 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4070 TriggerType:PUSH TriggerID:4900d684fedd60206559131a3d9eb2dde2c86125
Hash:eb8c0fc6d97f6e928e2a1c58bfb2c978096665e7 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143077006 TriggerType:PUSH TriggerID:eb8c0fc6d97f6e928e2a1c58bfb2c978096665e7
Hash:eb8c0fc6d97f6e928e2a1c58bfb2c978096665e7 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4091 TriggerType:PUSH TriggerID:eb8c0fc6d97f6e928e2a1c58bfb2c978096665e7
Hash:eb8c0fc6d97f6e928e2a1c58bfb2c978096665e7 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/143077006 TriggerType:MANUAL TriggerID:570976914
-->
## CI report:
* 68e5c62f5520559749307a6e2a2667434d5754cf Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142609810) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3971)
* 4900d684fedd60206559131a3d9eb2dde2c86125 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142978212) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4070)
* eb8c0fc6d97f6e928e2a1c58bfb2c978096665e7 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/143077006) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4091)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10716:
[FLINK-15367][runtime] Handle backwards compatibility of
"taskmanager.heap.size" differently for standalone / active setups
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10716: [FLINK-15367][runtime] Handle backwards compatibility of "taskmanager.heap.size" differently for standalone / active setups
URL: https://github.com/apache/flink/pull/10716#issuecomment-569571340
<!--
Meta data
Hash:68e5c62f5520559749307a6e2a2667434d5754cf Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3971 TriggerType:PUSH TriggerID:68e5c62f5520559749307a6e2a2667434d5754cf
Hash:68e5c62f5520559749307a6e2a2667434d5754cf Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142609810 TriggerType:PUSH TriggerID:68e5c62f5520559749307a6e2a2667434d5754cf
Hash:4900d684fedd60206559131a3d9eb2dde2c86125 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142978212 TriggerType:PUSH TriggerID:4900d684fedd60206559131a3d9eb2dde2c86125
Hash:4900d684fedd60206559131a3d9eb2dde2c86125 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4070 TriggerType:PUSH TriggerID:4900d684fedd60206559131a3d9eb2dde2c86125
Hash:eb8c0fc6d97f6e928e2a1c58bfb2c978096665e7 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:eb8c0fc6d97f6e928e2a1c58bfb2c978096665e7
-->
## CI report:
* 68e5c62f5520559749307a6e2a2667434d5754cf Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142609810) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3971)
* 4900d684fedd60206559131a3d9eb2dde2c86125 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142978212) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4070)
* eb8c0fc6d97f6e928e2a1c58bfb2c978096665e7 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] tillrohrmann commented on a change in pull request #10716:
[FLINK-15367][runtime] Handle backwards compatibility of
"taskmanager.heap.size" differently for standalone / active setups
Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on a change in pull request #10716: [FLINK-15367][runtime] Handle backwards compatibility of "taskmanager.heap.size" differently for standalone / active setups
URL: https://github.com/apache/flink/pull/10716#discussion_r362779912
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/TaskExecutorResourceUtils.java
##########
@@ -688,4 +669,55 @@ public static Configuration adjustConfigurationForLocalExecution(final Configura
return modifiedConfig;
}
+
+ public static Configuration adjustConfigurationForStandaloneSetups(final Configuration configuration) {
+ return getConfigurationMapLegacyTaskManagerHeapSizeToConfigOption(
+ configuration, TaskManagerOptions.TOTAL_FLINK_MEMORY);
+ }
+
+ public static Configuration adjustConfigurationForContainerizedSetups(final Configuration configuration) {
+ return getConfigurationMapLegacyTaskManagerHeapSizeToConfigOption(
+ configuration, TaskManagerOptions.TOTAL_PROCESS_MEMORY);
+ }
+
+ private static Configuration getConfigurationMapLegacyTaskManagerHeapSizeToConfigOption(
+ final Configuration configuration, ConfigOption<MemorySize> configOption) {
+
+ final Optional<MemorySize> legacyHeapSizeOptional = getLegacyTaskManagerHeapMemoryIfExplicitlyConfigured(configuration);
+ if (legacyHeapSizeOptional.isPresent()) {
+ final Configuration copiedConfig = new Configuration(configuration);
+ copiedConfig.set(configOption, legacyHeapSizeOptional.get());
+ return copiedConfig;
+ }
+
+ return configuration;
Review comment:
This could be expressed slightly more succinct:
```
getLegacyTaskManagerHeapMemoryIfExplicitlyConfigured(null).map(legacyHeapSize -> {
final Configuration copiedConfiguration = new Configuration(configuration);
copiedConfiguration.set(configOption, legacyHeapSize);
return copiedConfiguration;
}).orElse(configuration);
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] tillrohrmann closed pull request #10716:
[FLINK-15367][runtime] Handle backwards compatibility of
"taskmanager.heap.size" differently for standalone / active setups
Posted by GitBox <gi...@apache.org>.
tillrohrmann closed pull request #10716: [FLINK-15367][runtime] Handle backwards compatibility of "taskmanager.heap.size" differently for standalone / active setups
URL: https://github.com/apache/flink/pull/10716
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10716:
[FLINK-15367][runtime] Handle backwards compatibility of
"taskmanager.heap.size" differently for standalone / active setups
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10716: [FLINK-15367][runtime] Handle backwards compatibility of "taskmanager.heap.size" differently for standalone / active setups
URL: https://github.com/apache/flink/pull/10716#issuecomment-569571340
<!--
Meta data
Hash:68e5c62f5520559749307a6e2a2667434d5754cf Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3971 TriggerType:PUSH TriggerID:68e5c62f5520559749307a6e2a2667434d5754cf
Hash:68e5c62f5520559749307a6e2a2667434d5754cf Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142609810 TriggerType:PUSH TriggerID:68e5c62f5520559749307a6e2a2667434d5754cf
Hash:4900d684fedd60206559131a3d9eb2dde2c86125 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142978212 TriggerType:PUSH TriggerID:4900d684fedd60206559131a3d9eb2dde2c86125
Hash:4900d684fedd60206559131a3d9eb2dde2c86125 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4070 TriggerType:PUSH TriggerID:4900d684fedd60206559131a3d9eb2dde2c86125
Hash:eb8c0fc6d97f6e928e2a1c58bfb2c978096665e7 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143077006 TriggerType:PUSH TriggerID:eb8c0fc6d97f6e928e2a1c58bfb2c978096665e7
Hash:eb8c0fc6d97f6e928e2a1c58bfb2c978096665e7 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4091 TriggerType:PUSH TriggerID:eb8c0fc6d97f6e928e2a1c58bfb2c978096665e7
Hash:eb8c0fc6d97f6e928e2a1c58bfb2c978096665e7 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143077006 TriggerType:MANUAL TriggerID:570976914
Hash:eb8c0fc6d97f6e928e2a1c58bfb2c978096665e7 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4091 TriggerType:MANUAL TriggerID:570976914
Hash:eb8c0fc6d97f6e928e2a1c58bfb2c978096665e7 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143077006 TriggerType:MANUAL TriggerID:570983817
Hash:eb8c0fc6d97f6e928e2a1c58bfb2c978096665e7 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4091 TriggerType:MANUAL TriggerID:570983817
Hash:c314e09956b49005a7b1263090794e9ee7cc2296 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143229041 TriggerType:PUSH TriggerID:c314e09956b49005a7b1263090794e9ee7cc2296
Hash:c314e09956b49005a7b1263090794e9ee7cc2296 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4125 TriggerType:PUSH TriggerID:c314e09956b49005a7b1263090794e9ee7cc2296
-->
## CI report:
* 68e5c62f5520559749307a6e2a2667434d5754cf Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142609810) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3971)
* 4900d684fedd60206559131a3d9eb2dde2c86125 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142978212) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4070)
* eb8c0fc6d97f6e928e2a1c58bfb2c978096665e7 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143077006) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4091)
* c314e09956b49005a7b1263090794e9ee7cc2296 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143229041) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4125)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10716:
[FLINK-15367][runtime] Handle backwards compatibility of
"taskmanager.heap.size" differently for standalone / active setups
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10716: [FLINK-15367][runtime] Handle backwards compatibility of "taskmanager.heap.size" differently for standalone / active setups
URL: https://github.com/apache/flink/pull/10716#issuecomment-569571340
<!--
Meta data
Hash:68e5c62f5520559749307a6e2a2667434d5754cf Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3971 TriggerType:PUSH TriggerID:68e5c62f5520559749307a6e2a2667434d5754cf
Hash:68e5c62f5520559749307a6e2a2667434d5754cf Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142609810 TriggerType:PUSH TriggerID:68e5c62f5520559749307a6e2a2667434d5754cf
Hash:4900d684fedd60206559131a3d9eb2dde2c86125 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142978212 TriggerType:PUSH TriggerID:4900d684fedd60206559131a3d9eb2dde2c86125
Hash:4900d684fedd60206559131a3d9eb2dde2c86125 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4070 TriggerType:PUSH TriggerID:4900d684fedd60206559131a3d9eb2dde2c86125
-->
## CI report:
* 68e5c62f5520559749307a6e2a2667434d5754cf Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142609810) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3971)
* 4900d684fedd60206559131a3d9eb2dde2c86125 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142978212) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4070)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10716:
[FLINK-15367][runtime] Handle backwards compatibility of
"taskmanager.heap.size" differently for standalone / active setups
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10716: [FLINK-15367][runtime] Handle backwards compatibility of "taskmanager.heap.size" differently for standalone / active setups
URL: https://github.com/apache/flink/pull/10716#issuecomment-569571340
<!--
Meta data
Hash:68e5c62f5520559749307a6e2a2667434d5754cf Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3971 TriggerType:PUSH TriggerID:68e5c62f5520559749307a6e2a2667434d5754cf
Hash:68e5c62f5520559749307a6e2a2667434d5754cf Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142609810 TriggerType:PUSH TriggerID:68e5c62f5520559749307a6e2a2667434d5754cf
Hash:4900d684fedd60206559131a3d9eb2dde2c86125 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142978212 TriggerType:PUSH TriggerID:4900d684fedd60206559131a3d9eb2dde2c86125
Hash:4900d684fedd60206559131a3d9eb2dde2c86125 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4070 TriggerType:PUSH TriggerID:4900d684fedd60206559131a3d9eb2dde2c86125
Hash:eb8c0fc6d97f6e928e2a1c58bfb2c978096665e7 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143077006 TriggerType:PUSH TriggerID:eb8c0fc6d97f6e928e2a1c58bfb2c978096665e7
Hash:eb8c0fc6d97f6e928e2a1c58bfb2c978096665e7 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4091 TriggerType:PUSH TriggerID:eb8c0fc6d97f6e928e2a1c58bfb2c978096665e7
Hash:eb8c0fc6d97f6e928e2a1c58bfb2c978096665e7 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143077006 TriggerType:MANUAL TriggerID:570976914
Hash:eb8c0fc6d97f6e928e2a1c58bfb2c978096665e7 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4091 TriggerType:MANUAL TriggerID:570976914
Hash:eb8c0fc6d97f6e928e2a1c58bfb2c978096665e7 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/143077006 TriggerType:MANUAL TriggerID:570983817
Hash:eb8c0fc6d97f6e928e2a1c58bfb2c978096665e7 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4091 TriggerType:MANUAL TriggerID:570983817
-->
## CI report:
* 68e5c62f5520559749307a6e2a2667434d5754cf Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142609810) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3971)
* 4900d684fedd60206559131a3d9eb2dde2c86125 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142978212) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4070)
* eb8c0fc6d97f6e928e2a1c58bfb2c978096665e7 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/143077006) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4091)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #10716: [FLINK-15367][runtime]
Handle backwards compatibility of "taskmanager.heap.size" differently for
standalone / active setups
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10716: [FLINK-15367][runtime] Handle backwards compatibility of "taskmanager.heap.size" differently for standalone / active setups
URL: https://github.com/apache/flink/pull/10716#issuecomment-569571340
<!--
Meta data
Hash:68e5c62f5520559749307a6e2a2667434d5754cf Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:68e5c62f5520559749307a6e2a2667434d5754cf
-->
## CI report:
* 68e5c62f5520559749307a6e2a2667434d5754cf UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10716:
[FLINK-15367][runtime] Handle backwards compatibility of
"taskmanager.heap.size" differently for standalone / active setups
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10716: [FLINK-15367][runtime] Handle backwards compatibility of "taskmanager.heap.size" differently for standalone / active setups
URL: https://github.com/apache/flink/pull/10716#issuecomment-569571340
<!--
Meta data
Hash:68e5c62f5520559749307a6e2a2667434d5754cf Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3971 TriggerType:PUSH TriggerID:68e5c62f5520559749307a6e2a2667434d5754cf
Hash:68e5c62f5520559749307a6e2a2667434d5754cf Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142609810 TriggerType:PUSH TriggerID:68e5c62f5520559749307a6e2a2667434d5754cf
Hash:4900d684fedd60206559131a3d9eb2dde2c86125 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142978212 TriggerType:PUSH TriggerID:4900d684fedd60206559131a3d9eb2dde2c86125
Hash:4900d684fedd60206559131a3d9eb2dde2c86125 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4070 TriggerType:PUSH TriggerID:4900d684fedd60206559131a3d9eb2dde2c86125
Hash:eb8c0fc6d97f6e928e2a1c58bfb2c978096665e7 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143077006 TriggerType:PUSH TriggerID:eb8c0fc6d97f6e928e2a1c58bfb2c978096665e7
Hash:eb8c0fc6d97f6e928e2a1c58bfb2c978096665e7 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4091 TriggerType:PUSH TriggerID:eb8c0fc6d97f6e928e2a1c58bfb2c978096665e7
Hash:eb8c0fc6d97f6e928e2a1c58bfb2c978096665e7 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143077006 TriggerType:MANUAL TriggerID:570976914
Hash:eb8c0fc6d97f6e928e2a1c58bfb2c978096665e7 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4091 TriggerType:MANUAL TriggerID:570976914
Hash:eb8c0fc6d97f6e928e2a1c58bfb2c978096665e7 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/143077006 TriggerType:MANUAL TriggerID:570983817
-->
## CI report:
* 68e5c62f5520559749307a6e2a2667434d5754cf Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142609810) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3971)
* 4900d684fedd60206559131a3d9eb2dde2c86125 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142978212) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4070)
* eb8c0fc6d97f6e928e2a1c58bfb2c978096665e7 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/143077006) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4091)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10716:
[FLINK-15367][runtime] Handle backwards compatibility of
"taskmanager.heap.size" differently for standalone / active setups
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10716: [FLINK-15367][runtime] Handle backwards compatibility of "taskmanager.heap.size" differently for standalone / active setups
URL: https://github.com/apache/flink/pull/10716#issuecomment-569571340
<!--
Meta data
Hash:68e5c62f5520559749307a6e2a2667434d5754cf Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3971 TriggerType:PUSH TriggerID:68e5c62f5520559749307a6e2a2667434d5754cf
Hash:68e5c62f5520559749307a6e2a2667434d5754cf Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142609810 TriggerType:PUSH TriggerID:68e5c62f5520559749307a6e2a2667434d5754cf
Hash:4900d684fedd60206559131a3d9eb2dde2c86125 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:4900d684fedd60206559131a3d9eb2dde2c86125
-->
## CI report:
* 68e5c62f5520559749307a6e2a2667434d5754cf Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142609810) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3971)
* 4900d684fedd60206559131a3d9eb2dde2c86125 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10716:
[FLINK-15367][runtime] Handle backwards compatibility of
"taskmanager.heap.size" differently for standalone / active setups
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10716: [FLINK-15367][runtime] Handle backwards compatibility of "taskmanager.heap.size" differently for standalone / active setups
URL: https://github.com/apache/flink/pull/10716#issuecomment-569571340
<!--
Meta data
Hash:68e5c62f5520559749307a6e2a2667434d5754cf Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3971 TriggerType:PUSH TriggerID:68e5c62f5520559749307a6e2a2667434d5754cf
Hash:68e5c62f5520559749307a6e2a2667434d5754cf Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142609810 TriggerType:PUSH TriggerID:68e5c62f5520559749307a6e2a2667434d5754cf
Hash:4900d684fedd60206559131a3d9eb2dde2c86125 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142978212 TriggerType:PUSH TriggerID:4900d684fedd60206559131a3d9eb2dde2c86125
Hash:4900d684fedd60206559131a3d9eb2dde2c86125 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4070 TriggerType:PUSH TriggerID:4900d684fedd60206559131a3d9eb2dde2c86125
Hash:eb8c0fc6d97f6e928e2a1c58bfb2c978096665e7 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143077006 TriggerType:PUSH TriggerID:eb8c0fc6d97f6e928e2a1c58bfb2c978096665e7
Hash:eb8c0fc6d97f6e928e2a1c58bfb2c978096665e7 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4091 TriggerType:PUSH TriggerID:eb8c0fc6d97f6e928e2a1c58bfb2c978096665e7
-->
## CI report:
* 68e5c62f5520559749307a6e2a2667434d5754cf Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142609810) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3971)
* 4900d684fedd60206559131a3d9eb2dde2c86125 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142978212) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4070)
* eb8c0fc6d97f6e928e2a1c58bfb2c978096665e7 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143077006) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4091)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10716:
[FLINK-15367][runtime] Handle backwards compatibility of
"taskmanager.heap.size" differently for standalone / active setups
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10716: [FLINK-15367][runtime] Handle backwards compatibility of "taskmanager.heap.size" differently for standalone / active setups
URL: https://github.com/apache/flink/pull/10716#issuecomment-569571340
<!--
Meta data
Hash:68e5c62f5520559749307a6e2a2667434d5754cf Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3971 TriggerType:PUSH TriggerID:68e5c62f5520559749307a6e2a2667434d5754cf
Hash:68e5c62f5520559749307a6e2a2667434d5754cf Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142609810 TriggerType:PUSH TriggerID:68e5c62f5520559749307a6e2a2667434d5754cf
Hash:4900d684fedd60206559131a3d9eb2dde2c86125 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142978212 TriggerType:PUSH TriggerID:4900d684fedd60206559131a3d9eb2dde2c86125
Hash:4900d684fedd60206559131a3d9eb2dde2c86125 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4070 TriggerType:PUSH TriggerID:4900d684fedd60206559131a3d9eb2dde2c86125
Hash:eb8c0fc6d97f6e928e2a1c58bfb2c978096665e7 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143077006 TriggerType:PUSH TriggerID:eb8c0fc6d97f6e928e2a1c58bfb2c978096665e7
Hash:eb8c0fc6d97f6e928e2a1c58bfb2c978096665e7 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4091 TriggerType:PUSH TriggerID:eb8c0fc6d97f6e928e2a1c58bfb2c978096665e7
Hash:eb8c0fc6d97f6e928e2a1c58bfb2c978096665e7 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143077006 TriggerType:MANUAL TriggerID:570976914
Hash:eb8c0fc6d97f6e928e2a1c58bfb2c978096665e7 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4091 TriggerType:MANUAL TriggerID:570976914
Hash:eb8c0fc6d97f6e928e2a1c58bfb2c978096665e7 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143077006 TriggerType:MANUAL TriggerID:570983817
Hash:eb8c0fc6d97f6e928e2a1c58bfb2c978096665e7 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4091 TriggerType:MANUAL TriggerID:570983817
-->
## CI report:
* 68e5c62f5520559749307a6e2a2667434d5754cf Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142609810) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3971)
* 4900d684fedd60206559131a3d9eb2dde2c86125 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142978212) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4070)
* eb8c0fc6d97f6e928e2a1c58bfb2c978096665e7 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143077006) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4091)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10716:
[FLINK-15367][runtime] Handle backwards compatibility of
"taskmanager.heap.size" differently for standalone / active setups
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10716: [FLINK-15367][runtime] Handle backwards compatibility of "taskmanager.heap.size" differently for standalone / active setups
URL: https://github.com/apache/flink/pull/10716#issuecomment-569571340
<!--
Meta data
Hash:68e5c62f5520559749307a6e2a2667434d5754cf Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3971 TriggerType:PUSH TriggerID:68e5c62f5520559749307a6e2a2667434d5754cf
Hash:68e5c62f5520559749307a6e2a2667434d5754cf Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142609810 TriggerType:PUSH TriggerID:68e5c62f5520559749307a6e2a2667434d5754cf
Hash:4900d684fedd60206559131a3d9eb2dde2c86125 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/142978212 TriggerType:PUSH TriggerID:4900d684fedd60206559131a3d9eb2dde2c86125
Hash:4900d684fedd60206559131a3d9eb2dde2c86125 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4070 TriggerType:PUSH TriggerID:4900d684fedd60206559131a3d9eb2dde2c86125
-->
## CI report:
* 68e5c62f5520559749307a6e2a2667434d5754cf Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142609810) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3971)
* 4900d684fedd60206559131a3d9eb2dde2c86125 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/142978212) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4070)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] tillrohrmann commented on a change in pull request #10716:
[FLINK-15367][runtime] Handle backwards compatibility of
"taskmanager.heap.size" differently for standalone / active setups
Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on a change in pull request #10716: [FLINK-15367][runtime] Handle backwards compatibility of "taskmanager.heap.size" differently for standalone / active setups
URL: https://github.com/apache/flink/pull/10716#discussion_r362779008
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/TaskExecutorResourceUtils.java
##########
@@ -688,4 +669,55 @@ public static Configuration adjustConfigurationForLocalExecution(final Configura
return modifiedConfig;
}
+
+ public static Configuration adjustConfigurationForStandaloneSetups(final Configuration configuration) {
+ return getConfigurationMapLegacyTaskManagerHeapSizeToConfigOption(
+ configuration, TaskManagerOptions.TOTAL_FLINK_MEMORY);
+ }
+
+ public static Configuration adjustConfigurationForContainerizedSetups(final Configuration configuration) {
+ return getConfigurationMapLegacyTaskManagerHeapSizeToConfigOption(
+ configuration, TaskManagerOptions.TOTAL_PROCESS_MEMORY);
+ }
+
+ private static Configuration getConfigurationMapLegacyTaskManagerHeapSizeToConfigOption(
+ final Configuration configuration, ConfigOption<MemorySize> configOption) {
+
+ final Optional<MemorySize> legacyHeapSizeOptional = getLegacyTaskManagerHeapMemoryIfExplicitlyConfigured(configuration);
+ if (legacyHeapSizeOptional.isPresent()) {
+ final Configuration copiedConfig = new Configuration(configuration);
+ copiedConfig.set(configOption, legacyHeapSizeOptional.get());
+ return copiedConfig;
+ }
+
+ return configuration;
+ }
Review comment:
What happens if `configOption` has been set? I think then new option should have precedence. We should also add tests for this scenario.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] xintongsong commented on issue #10716:
[FLINK-15367][runtime] Handle backwards compatibility of
"taskmanager.heap.size" differently for standalone / active setups
Posted by GitBox <gi...@apache.org>.
xintongsong commented on issue #10716: [FLINK-15367][runtime] Handle backwards compatibility of "taskmanager.heap.size" differently for standalone / active setups
URL: https://github.com/apache/flink/pull/10716#issuecomment-570750908
@tillrohrmann Thank you for the review. I've addressed your comments.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10716:
[FLINK-15367][runtime] Handle backwards compatibility of
"taskmanager.heap.size" differently for standalone / active setups
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10716: [FLINK-15367][runtime] Handle backwards compatibility of "taskmanager.heap.size" differently for standalone / active setups
URL: https://github.com/apache/flink/pull/10716#issuecomment-569571340
<!--
Meta data
Hash:68e5c62f5520559749307a6e2a2667434d5754cf Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3971 TriggerType:PUSH TriggerID:68e5c62f5520559749307a6e2a2667434d5754cf
Hash:68e5c62f5520559749307a6e2a2667434d5754cf Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142609810 TriggerType:PUSH TriggerID:68e5c62f5520559749307a6e2a2667434d5754cf
-->
## CI report:
* 68e5c62f5520559749307a6e2a2667434d5754cf Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142609810) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3971)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] tillrohrmann commented on a change in pull request #10716:
[FLINK-15367][runtime] Handle backwards compatibility of
"taskmanager.heap.size" differently for standalone / active setups
Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on a change in pull request #10716: [FLINK-15367][runtime] Handle backwards compatibility of "taskmanager.heap.size" differently for standalone / active setups
URL: https://github.com/apache/flink/pull/10716#discussion_r362780210
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/TaskExecutorResourceUtils.java
##########
@@ -688,4 +669,55 @@ public static Configuration adjustConfigurationForLocalExecution(final Configura
return modifiedConfig;
}
+
+ public static Configuration adjustConfigurationForStandaloneSetups(final Configuration configuration) {
+ return getConfigurationMapLegacyTaskManagerHeapSizeToConfigOption(
+ configuration, TaskManagerOptions.TOTAL_FLINK_MEMORY);
+ }
+
+ public static Configuration adjustConfigurationForContainerizedSetups(final Configuration configuration) {
+ return getConfigurationMapLegacyTaskManagerHeapSizeToConfigOption(
+ configuration, TaskManagerOptions.TOTAL_PROCESS_MEMORY);
+ }
Review comment:
I think this method rather belongs to `ActiveResourceManagerFactory` than to `TaskExecutorResourceUtils`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10716:
[FLINK-15367][runtime] Handle backwards compatibility of
"taskmanager.heap.size" differently for standalone / active setups
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10716: [FLINK-15367][runtime] Handle backwards compatibility of "taskmanager.heap.size" differently for standalone / active setups
URL: https://github.com/apache/flink/pull/10716#issuecomment-569571340
<!--
Meta data
Hash:68e5c62f5520559749307a6e2a2667434d5754cf Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3971 TriggerType:PUSH TriggerID:68e5c62f5520559749307a6e2a2667434d5754cf
Hash:68e5c62f5520559749307a6e2a2667434d5754cf Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142609810 TriggerType:PUSH TriggerID:68e5c62f5520559749307a6e2a2667434d5754cf
Hash:4900d684fedd60206559131a3d9eb2dde2c86125 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142978212 TriggerType:PUSH TriggerID:4900d684fedd60206559131a3d9eb2dde2c86125
Hash:4900d684fedd60206559131a3d9eb2dde2c86125 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4070 TriggerType:PUSH TriggerID:4900d684fedd60206559131a3d9eb2dde2c86125
Hash:eb8c0fc6d97f6e928e2a1c58bfb2c978096665e7 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143077006 TriggerType:PUSH TriggerID:eb8c0fc6d97f6e928e2a1c58bfb2c978096665e7
Hash:eb8c0fc6d97f6e928e2a1c58bfb2c978096665e7 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4091 TriggerType:PUSH TriggerID:eb8c0fc6d97f6e928e2a1c58bfb2c978096665e7
Hash:eb8c0fc6d97f6e928e2a1c58bfb2c978096665e7 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143077006 TriggerType:MANUAL TriggerID:570976914
Hash:eb8c0fc6d97f6e928e2a1c58bfb2c978096665e7 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4091 TriggerType:MANUAL TriggerID:570976914
Hash:eb8c0fc6d97f6e928e2a1c58bfb2c978096665e7 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143077006 TriggerType:MANUAL TriggerID:570983817
Hash:eb8c0fc6d97f6e928e2a1c58bfb2c978096665e7 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4091 TriggerType:MANUAL TriggerID:570983817
Hash:c314e09956b49005a7b1263090794e9ee7cc2296 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:c314e09956b49005a7b1263090794e9ee7cc2296
-->
## CI report:
* 68e5c62f5520559749307a6e2a2667434d5754cf Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142609810) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3971)
* 4900d684fedd60206559131a3d9eb2dde2c86125 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142978212) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4070)
* eb8c0fc6d97f6e928e2a1c58bfb2c978096665e7 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143077006) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4091)
* c314e09956b49005a7b1263090794e9ee7cc2296 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10716:
[FLINK-15367][runtime] Handle backwards compatibility of
"taskmanager.heap.size" differently for standalone / active setups
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10716: [FLINK-15367][runtime] Handle backwards compatibility of "taskmanager.heap.size" differently for standalone / active setups
URL: https://github.com/apache/flink/pull/10716#issuecomment-569571340
<!--
Meta data
Hash:68e5c62f5520559749307a6e2a2667434d5754cf Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3971 TriggerType:PUSH TriggerID:68e5c62f5520559749307a6e2a2667434d5754cf
Hash:68e5c62f5520559749307a6e2a2667434d5754cf Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142609810 TriggerType:PUSH TriggerID:68e5c62f5520559749307a6e2a2667434d5754cf
Hash:4900d684fedd60206559131a3d9eb2dde2c86125 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/142978212 TriggerType:PUSH TriggerID:4900d684fedd60206559131a3d9eb2dde2c86125
Hash:4900d684fedd60206559131a3d9eb2dde2c86125 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4070 TriggerType:PUSH TriggerID:4900d684fedd60206559131a3d9eb2dde2c86125
-->
## CI report:
* 68e5c62f5520559749307a6e2a2667434d5754cf Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142609810) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3971)
* 4900d684fedd60206559131a3d9eb2dde2c86125 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/142978212) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4070)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] xintongsong commented on issue #10716: [FLINK-15367] Handle
backwards compatibility of "taskmanager.heap.size" differently for
standalone / active setups
Posted by GitBox <gi...@apache.org>.
xintongsong commented on issue #10716: [FLINK-15367] Handle backwards compatibility of "taskmanager.heap.size" differently for standalone / active setups
URL: https://github.com/apache/flink/pull/10716#issuecomment-569565647
cc @azagrebin @tillrohrmann @StephanEwen
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] xintongsong commented on issue #10716:
[FLINK-15367][runtime] Handle backwards compatibility of
"taskmanager.heap.size" differently for standalone / active setups
Posted by GitBox <gi...@apache.org>.
xintongsong commented on issue #10716: [FLINK-15367][runtime] Handle backwards compatibility of "taskmanager.heap.size" differently for standalone / active setups
URL: https://github.com/apache/flink/pull/10716#issuecomment-570976914
@flinkbot run travis
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10716:
[FLINK-15367][runtime] Handle backwards compatibility of
"taskmanager.heap.size" differently for standalone / active setups
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10716: [FLINK-15367][runtime] Handle backwards compatibility of "taskmanager.heap.size" differently for standalone / active setups
URL: https://github.com/apache/flink/pull/10716#issuecomment-569571340
<!--
Meta data
Hash:68e5c62f5520559749307a6e2a2667434d5754cf Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3971 TriggerType:PUSH TriggerID:68e5c62f5520559749307a6e2a2667434d5754cf
Hash:68e5c62f5520559749307a6e2a2667434d5754cf Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142609810 TriggerType:PUSH TriggerID:68e5c62f5520559749307a6e2a2667434d5754cf
Hash:4900d684fedd60206559131a3d9eb2dde2c86125 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142978212 TriggerType:PUSH TriggerID:4900d684fedd60206559131a3d9eb2dde2c86125
Hash:4900d684fedd60206559131a3d9eb2dde2c86125 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4070 TriggerType:PUSH TriggerID:4900d684fedd60206559131a3d9eb2dde2c86125
Hash:eb8c0fc6d97f6e928e2a1c58bfb2c978096665e7 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143077006 TriggerType:PUSH TriggerID:eb8c0fc6d97f6e928e2a1c58bfb2c978096665e7
Hash:eb8c0fc6d97f6e928e2a1c58bfb2c978096665e7 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4091 TriggerType:PUSH TriggerID:eb8c0fc6d97f6e928e2a1c58bfb2c978096665e7
Hash:eb8c0fc6d97f6e928e2a1c58bfb2c978096665e7 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143077006 TriggerType:MANUAL TriggerID:570976914
Hash:eb8c0fc6d97f6e928e2a1c58bfb2c978096665e7 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4091 TriggerType:MANUAL TriggerID:570976914
Hash:eb8c0fc6d97f6e928e2a1c58bfb2c978096665e7 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143077006 TriggerType:MANUAL TriggerID:570983817
Hash:eb8c0fc6d97f6e928e2a1c58bfb2c978096665e7 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4091 TriggerType:MANUAL TriggerID:570983817
Hash:c314e09956b49005a7b1263090794e9ee7cc2296 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/143229041 TriggerType:PUSH TriggerID:c314e09956b49005a7b1263090794e9ee7cc2296
Hash:c314e09956b49005a7b1263090794e9ee7cc2296 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4125 TriggerType:PUSH TriggerID:c314e09956b49005a7b1263090794e9ee7cc2296
-->
## CI report:
* 68e5c62f5520559749307a6e2a2667434d5754cf Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142609810) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3971)
* 4900d684fedd60206559131a3d9eb2dde2c86125 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142978212) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4070)
* eb8c0fc6d97f6e928e2a1c58bfb2c978096665e7 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143077006) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4091)
* c314e09956b49005a7b1263090794e9ee7cc2296 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/143229041) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4125)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10716:
[FLINK-15367][runtime] Handle backwards compatibility of
"taskmanager.heap.size" differently for standalone / active setups
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10716: [FLINK-15367][runtime] Handle backwards compatibility of "taskmanager.heap.size" differently for standalone / active setups
URL: https://github.com/apache/flink/pull/10716#issuecomment-569571340
<!--
Meta data
Hash:68e5c62f5520559749307a6e2a2667434d5754cf Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3971 TriggerType:PUSH TriggerID:68e5c62f5520559749307a6e2a2667434d5754cf
Hash:68e5c62f5520559749307a6e2a2667434d5754cf Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142609810 TriggerType:PUSH TriggerID:68e5c62f5520559749307a6e2a2667434d5754cf
Hash:4900d684fedd60206559131a3d9eb2dde2c86125 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142978212 TriggerType:PUSH TriggerID:4900d684fedd60206559131a3d9eb2dde2c86125
Hash:4900d684fedd60206559131a3d9eb2dde2c86125 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4070 TriggerType:PUSH TriggerID:4900d684fedd60206559131a3d9eb2dde2c86125
Hash:eb8c0fc6d97f6e928e2a1c58bfb2c978096665e7 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/143077006 TriggerType:PUSH TriggerID:eb8c0fc6d97f6e928e2a1c58bfb2c978096665e7
Hash:eb8c0fc6d97f6e928e2a1c58bfb2c978096665e7 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4091 TriggerType:PUSH TriggerID:eb8c0fc6d97f6e928e2a1c58bfb2c978096665e7
-->
## CI report:
* 68e5c62f5520559749307a6e2a2667434d5754cf Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142609810) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3971)
* 4900d684fedd60206559131a3d9eb2dde2c86125 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142978212) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4070)
* eb8c0fc6d97f6e928e2a1c58bfb2c978096665e7 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/143077006) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4091)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] tillrohrmann commented on a change in pull request #10716:
[FLINK-15367][runtime] Handle backwards compatibility of
"taskmanager.heap.size" differently for standalone / active setups
Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on a change in pull request #10716: [FLINK-15367][runtime] Handle backwards compatibility of "taskmanager.heap.size" differently for standalone / active setups
URL: https://github.com/apache/flink/pull/10716#discussion_r362782717
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/TaskExecutorResourceUtils.java
##########
@@ -688,4 +669,55 @@ public static Configuration adjustConfigurationForLocalExecution(final Configura
return modifiedConfig;
}
+
+ public static Configuration adjustConfigurationForStandaloneSetups(final Configuration configuration) {
+ return getConfigurationMapLegacyTaskManagerHeapSizeToConfigOption(
+ configuration, TaskManagerOptions.TOTAL_FLINK_MEMORY);
+ }
+
+ public static Configuration adjustConfigurationForContainerizedSetups(final Configuration configuration) {
+ return getConfigurationMapLegacyTaskManagerHeapSizeToConfigOption(
+ configuration, TaskManagerOptions.TOTAL_PROCESS_MEMORY);
+ }
+
+ private static Configuration getConfigurationMapLegacyTaskManagerHeapSizeToConfigOption(
+ final Configuration configuration, ConfigOption<MemorySize> configOption) {
+
+ final Optional<MemorySize> legacyHeapSizeOptional = getLegacyTaskManagerHeapMemoryIfExplicitlyConfigured(configuration);
+ if (legacyHeapSizeOptional.isPresent()) {
+ final Configuration copiedConfig = new Configuration(configuration);
+ copiedConfig.set(configOption, legacyHeapSizeOptional.get());
Review comment:
I think it would be good to log that we are defaulting to the legacy memory configuration on `INFO`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] tillrohrmann commented on a change in pull request #10716:
[FLINK-15367][runtime] Handle backwards compatibility of
"taskmanager.heap.size" differently for standalone / active setups
Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on a change in pull request #10716: [FLINK-15367][runtime] Handle backwards compatibility of "taskmanager.heap.size" differently for standalone / active setups
URL: https://github.com/apache/flink/pull/10716#discussion_r362780302
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/TaskExecutorResourceUtils.java
##########
@@ -688,4 +669,55 @@ public static Configuration adjustConfigurationForLocalExecution(final Configura
return modifiedConfig;
}
+
+ public static Configuration adjustConfigurationForStandaloneSetups(final Configuration configuration) {
+ return getConfigurationMapLegacyTaskManagerHeapSizeToConfigOption(
+ configuration, TaskManagerOptions.TOTAL_FLINK_MEMORY);
+ }
Review comment:
Same here, just to `BashJavaUtils`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #10716: [FLINK-15367][runtime]
Handle backwards compatibility of "taskmanager.heap.size" differently for
standalone / active setups
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10716: [FLINK-15367][runtime] Handle backwards compatibility of "taskmanager.heap.size" differently for standalone / active setups
URL: https://github.com/apache/flink/pull/10716#issuecomment-569565909
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 68e5c62f5520559749307a6e2a2667434d5754cf (Mon Dec 30 02:31:45 UTC 2019)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10716:
[FLINK-15367][runtime] Handle backwards compatibility of
"taskmanager.heap.size" differently for standalone / active setups
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10716: [FLINK-15367][runtime] Handle backwards compatibility of "taskmanager.heap.size" differently for standalone / active setups
URL: https://github.com/apache/flink/pull/10716#issuecomment-569571340
<!--
Meta data
Hash:68e5c62f5520559749307a6e2a2667434d5754cf Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3971 TriggerType:PUSH TriggerID:68e5c62f5520559749307a6e2a2667434d5754cf
Hash:68e5c62f5520559749307a6e2a2667434d5754cf Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/142609810 TriggerType:PUSH TriggerID:68e5c62f5520559749307a6e2a2667434d5754cf
-->
## CI report:
* 68e5c62f5520559749307a6e2a2667434d5754cf Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/142609810) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3971)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] xintongsong commented on issue #10716:
[FLINK-15367][runtime] Handle backwards compatibility of
"taskmanager.heap.size" differently for standalone / active setups
Posted by GitBox <gi...@apache.org>.
xintongsong commented on issue #10716: [FLINK-15367][runtime] Handle backwards compatibility of "taskmanager.heap.size" differently for standalone / active setups
URL: https://github.com/apache/flink/pull/10716#issuecomment-570525171
Rebase master.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] tillrohrmann commented on a change in pull request #10716:
[FLINK-15367][runtime] Handle backwards compatibility of
"taskmanager.heap.size" differently for standalone / active setups
Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on a change in pull request #10716: [FLINK-15367][runtime] Handle backwards compatibility of "taskmanager.heap.size" differently for standalone / active setups
URL: https://github.com/apache/flink/pull/10716#discussion_r363245985
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/TaskExecutorResourceUtils.java
##########
@@ -688,4 +674,47 @@ public static Configuration adjustConfigurationForLocalExecution(final Configura
return modifiedConfig;
}
+
+ public static Configuration getConfigurationMapLegacyTaskManagerHeapSizeToConfigOption(
+ final Configuration configuration, ConfigOption<MemorySize> configOption) {
+
+ if (configuration.contains(configOption)) {
+ return configuration;
+ }
+
+ return getLegacyTaskManagerHeapMemoryIfExplicitlyConfigured(configuration).map(legacyHeapSize -> {
+ final Configuration copiedConfig = new Configuration(configuration);
+ copiedConfig.set(configOption, legacyHeapSize);
+ LOG.info("'{}' is not specified, use the configured deprecated task manager heap value for it.", configOption.key());
Review comment:
could add `legacyHeapSize` to logging statement to see what the value is.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services