You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2021/09/02 06:47:20 UTC
[GitHub] [ozone] JacksonYao287 commented on a change in pull request #2577: HDDS-5670. ContainerBalancer should get OzoneConfiguration from Conta…
JacksonYao287 commented on a change in pull request #2577:
URL: https://github.com/apache/ozone/pull/2577#discussion_r700792962
##########
File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/balancer/ContainerBalancerConfiguration.java
##########
@@ -111,10 +111,14 @@
*/
public ContainerBalancerConfiguration(
OzoneConfiguration ozoneConfiguration) {
- this.ozoneConfiguration = ozoneConfiguration;
+ if (ozoneConfiguration == null) {
Review comment:
actually, ozoneConfiguration should not be null. we'd better to use `Preconditions.checkNotNull` instead here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org