You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by AkihiroKitada <gi...@git.apache.org> on 2017/05/23 01:58:56 UTC
[GitHub] geode pull request #525: GEODE-2962: Add more messages for compact disk-stor...
GitHub user AkihiroKitada opened a pull request:
https://github.com/apache/geode/pull/525
GEODE-2962: Add more messages for compact disk-store
Added a message in the case that notExecutedMembers variable is null.
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
- [x] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
- [x] Is your initial contribution a single, squashed commit?
- [ ] Does `gradlew build` run cleanly?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/AkihiroKitada/geode feature/GEODE-2962
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/geode/pull/525.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #525
----
commit 12c83b5f6838ec720fd7e67db4f95b8b868cb896
Author: Akihiro Kitada <ak...@akitada-mcbk13.local>
Date: 2017-05-22T10:20:02Z
GEODE-2962: Add more messages for compact disk-store
Added a message in the case that notExecutedMembers variable is null.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode pull request #525: GEODE-2962: Add more messages for compact disk-stor...
Posted by AkihiroKitada <gi...@git.apache.org>.
Github user AkihiroKitada closed the pull request at:
https://github.com/apache/geode/pull/525
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode issue #525: GEODE-2962: Add more messages for compact disk-store
Posted by AkihiroKitada <gi...@git.apache.org>.
Github user AkihiroKitada commented on the issue:
https://github.com/apache/geode/pull/525
Hello Darrel,
I'm sorry to make this PR confused. I updated this PR from other environment and it made this PR cause some differences in terms of my fork.
I'll close this PR and create other one.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode issue #525: GEODE-2962: Add more messages for compact disk-store
Posted by metatype <gi...@git.apache.org>.
Github user metatype commented on the issue:
https://github.com/apache/geode/pull/525
Why is `notExecutedMembers` null? Is that the issue that should be addressed instead of changing the message?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode pull request #525: GEODE-2962: Add more messages for compact disk-stor...
Posted by AkihiroKitada <gi...@git.apache.org>.
Github user AkihiroKitada commented on a diff in the pull request:
https://github.com/apache/geode/pull/525#discussion_r118150229
--- Diff: geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/DiskStoreCommands.java ---
@@ -485,9 +485,14 @@ public Result compactDiskStore(
memberCompactInfo.clear();
}
String notExecutedMembers = CompactRequest.getNotExecutedMembers();
+ if (notExecutedMembers != null && !notExecutedMembers.isEmpty()) {
+ notExecutedMembers = "but was not send to " + notExecutedMembers;
+ } else {
+ notExecutedMembers = "all the members";
--- End diff --
Hello Darrel,
I remove redundant log message according to your suggestion.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode issue #525: GEODE-2962: Add more messages for compact disk-store
Posted by AkihiroKitada <gi...@git.apache.org>.
Github user AkihiroKitada commented on the issue:
https://github.com/apache/geode/pull/525
Do I need write test code for this minor change? If so, please let me know.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode issue #525: GEODE-2962: Add more messages for compact disk-store
Posted by dschneider-pivotal <gi...@git.apache.org>.
Github user dschneider-pivotal commented on the issue:
https://github.com/apache/geode/pull/525
Your diffs now show 51 files changed. It now shows a removal of deprecated FunctionService API. Perhaps you are picking this up from changes others made?
You might need to close this PR and start a new one but can you get it back only showing the changes you are making?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode pull request #525: GEODE-2962: Add more messages for compact disk-stor...
Posted by dschneider-pivotal <gi...@git.apache.org>.
Github user dschneider-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/525#discussion_r118057642
--- Diff: geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/DiskStoreCommands.java ---
@@ -485,9 +485,14 @@ public Result compactDiskStore(
memberCompactInfo.clear();
}
String notExecutedMembers = CompactRequest.getNotExecutedMembers();
+ if (notExecutedMembers != null && !notExecutedMembers.isEmpty()) {
+ notExecutedMembers = "but was not send to " + notExecutedMembers;
+ } else {
+ notExecutedMembers = "all the members";
--- End diff --
I think this log message only needs to say something if "notExecutedMembers" is not null and not empty.
No need for a message in the else. You will notice that immediately after this code is a report of what was compacted so it seem to me too verbose to say "I sent the request to everyone".
But it could be helpful to log a note of the members that did not receive the request.
So I think you should put the log lines 493-496 inside this if and get rid of the else.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---