You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tinkerpop.apache.org by okram <gi...@git.apache.org> on 2015/11/03 18:08:19 UTC

[GitHub] incubator-tinkerpop pull request: TINKERPOP3-768: MatchStep in OLA...

GitHub user okram opened a pull request:

    https://github.com/apache/incubator-tinkerpop/pull/134

    TINKERPOP3-768: MatchStep in OLAP should be smart about current vertex.

    https://issues.apache.org/jira/browse/TINKERPOP3-768
    
    The previous implementation of MatchStep was not biased to patterns that start at the current vertex. In OLTP, this is good. In OLAP, this is really really really bad as you are incuring a massive overhead with inter process communication. Thus, optimization, in OLAP, will sort the patterns first by whether the traverser needs to leave the current object location and then by TraversalType and then by multiplicity of the pattern. In the process, I cleaned up a few things here and there in MatchStep.
    
    Ran `mvn clean install` and all is good.
    
    VOTE +1.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/apache/incubator-tinkerpop TINKERPOP3-768

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-tinkerpop/pull/134.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #134
    
----
commit 956d7977f4507db8d51b0468604f3b214e0681b3
Author: Marko A. Rodriguez <ok...@gmail.com>
Date:   2015-11-03T16:16:39Z

    MatchStep is smart to bias patterns towards the local star graph to reduce inter-machine communication.

commit f644fb42b9f5e0f9216deb3f5e3088293e3ca13a
Author: Marko A. Rodriguez <ok...@gmail.com>
Date:   2015-11-03T17:05:25Z

    clean up tweaks to MatchStep optimization.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-tinkerpop pull request: TINKERPOP3-768: MatchStep in OLA...

Posted by PommeVerte <gi...@git.apache.org>.
Github user PommeVerte commented on the pull request:

    https://github.com/apache/incubator-tinkerpop/pull/134#issuecomment-153695854
  
    Tests pass for me as well. it all looks clean. 
    
    VOTE: +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-tinkerpop pull request: TINKERPOP3-768: MatchStep in OLA...

Posted by okram <gi...@git.apache.org>.
Github user okram commented on the pull request:

    https://github.com/apache/incubator-tinkerpop/pull/134#issuecomment-153428165
  
    @dkuppitz --- Spark integration tests passed. Giraph is still running (but the changes won't effect the integration test suites). 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-tinkerpop pull request: TINKERPOP3-768: MatchStep in OLA...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-tinkerpop/pull/134


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-tinkerpop pull request: TINKERPOP3-768: MatchStep in OLA...

Posted by dkuppitz <gi...@git.apache.org>.
Github user dkuppitz commented on the pull request:

    https://github.com/apache/incubator-tinkerpop/pull/134#issuecomment-153427584
  
    Code looks clean. I assume that the full integration test suite also passes.
    
    VOTE: +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---