You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@subversion.apache.org by ar...@apache.org on 2010/09/29 10:02:54 UTC

svn commit: r1002507 - /subversion/trunk/subversion/svnrdump/dump_editor.c

Author: artagnon
Date: Wed Sep 29 08:02:54 2010
New Revision: 1002507

URL: http://svn.apache.org/viewvc?rev=1002507&view=rev
Log:
svnrdump: dump_editor: Fix issue related to incorrect pool being used
for allocation certain variables.

* subversion/svnrdump/dump_editor.c

  (change_dir_prop): `deleted_props` should be allocated in the
  per-revision pool `eb->pool`.

  (apply_textdelta): `base_checksum` should be allocated in the
  per-revision pool `eb->pool`.

Modified:
    subversion/trunk/subversion/svnrdump/dump_editor.c

Modified: subversion/trunk/subversion/svnrdump/dump_editor.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/svnrdump/dump_editor.c?rev=1002507&r1=1002506&r2=1002507&view=diff
==============================================================================
--- subversion/trunk/subversion/svnrdump/dump_editor.c (original)
+++ subversion/trunk/subversion/svnrdump/dump_editor.c Wed Sep 29 08:02:54 2010
@@ -623,7 +623,7 @@ change_dir_prop(void *parent_baton,
     apr_hash_set(db->eb->props, apr_pstrdup(db->eb->pool, name),
                  APR_HASH_KEY_STRING, svn_string_dup(value, db->eb->pool));
   else
-    apr_hash_set(db->eb->deleted_props, apr_pstrdup(pool, name),
+    apr_hash_set(db->eb->deleted_props, apr_pstrdup(db->eb->pool, name),
                  APR_HASH_KEY_STRING, "");
 
   if (! db->written_out)
@@ -723,7 +723,7 @@ apply_textdelta(void *file_baton, const 
   svn_txdelta_to_svndiff2(&(hb->apply_handler), &(hb->apply_baton),
                           hb->delta_filestream, 0, hb->pool);
   eb->dump_text = TRUE;
-  eb->base_checksum = apr_pstrdup(pool, base_checksum);
+  eb->base_checksum = apr_pstrdup(eb->pool, base_checksum);
 
   /* The actual writing takes place when this function has
      finished. Set handler and handler_baton now so for