[GitHub] spark pull request: [SPARK-13992] Add support for off-heap caching

[JoshRosen <gi...@git.apache.org>]

Github user JoshRosen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/11805#discussion_r58147716
  
    --- Diff: core/src/main/scala/org/apache/spark/storage/StorageLevel.scala ---
    @@ -60,10 +60,7 @@ class StorageLevel private(
       assert(replication < 40, "Replication restricted to be less than 40 for calculating hash codes")
     
       if (useOffHeap) {
    -    require(!useDisk, "Off-heap storage level does not support using disk")
    -    require(!useMemory, "Off-heap storage level does not support using heap memory")
         require(!deserialized, "Off-heap storage level does not support deserialized storage")
    --- End diff --
    
    Unfortunately, it's not going to be super easy to do this right now because of how StorageLevel serves the dual purpose of being both a specification of how blocks should be stored and a description of how they're actually stored (i.e. an "effective storage level"). If we added this constraint, the logic for constructing effective storage levels would become much more complicated.
    
    Therefore, I think we should address this issue later and leave the code as-is for now.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org