You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/02/08 00:53:14 UTC

[GitHub] [spark] gatorsmile commented on a change in pull request #27413: [SPARK-29938][SQL][FOLLOW-UP] Improve AlterTableAddPartitionCommand

gatorsmile commented on a change in pull request #27413: [SPARK-29938][SQL][FOLLOW-UP] Improve AlterTableAddPartitionCommand
URL: https://github.com/apache/spark/pull/27413#discussion_r376670679
 
 

 ##########
 File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
 ##########
 @@ -2148,6 +2148,16 @@ object SQLConf {
     .booleanConf
     .createWithDefault(true)
 
+  val ADD_PARTITION_BATCH_SIZE =
+    buildConf("spark.sql.addPartitionInBatch.size")
+      .internal()
+      .doc("The number of partitions to be handled in one turn when use " +
+        "`AlterTableAddPartitionCommand` to add partitions into table. The smaller " +
 
 Review comment:
   We should avoid using the internal class name in the conf description and log/exception messages, since most readers are external end users who have no idea about the internal code. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org